[maps] clean up maps app state#73337
Merged
nreese merged 19 commits intoelastic:masterfrom Jul 30, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
commented
Jul 27, 2020
nreese
commented
Jul 27, 2020
| return this._appStateManager.getFilters() || []; | ||
| }; | ||
|
|
||
| _syncAppAndGlobalState = () => { |
Contributor
Author
There was a problem hiding this comment.
Removed _syncAppAndGlobalState and just inlined into _onQueryChange
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
nreese
commented
Jul 28, 2020
Contributor
Author
|
@elasticmachine merge upstream |
kindsun
reviewed
Jul 29, 2020
kindsun
reviewed
Jul 29, 2020
x-pack/plugins/maps/public/routing/routes/maps_app/maps_app_view.js
Outdated
Show resolved
Hide resolved
kindsun
reviewed
Jul 29, 2020
x-pack/plugins/maps/public/routing/routes/maps_app/maps_app_view.js
Outdated
Show resolved
Hide resolved
kindsun
reviewed
Jul 29, 2020
kindsun
reviewed
Jul 29, 2020
kindsun
approved these changes
Jul 29, 2020
Contributor
kindsun
left a comment
There was a problem hiding this comment.
lgtm! Thanks for a much-needed second pass on this 🙏
- code review
- tested locally in chrome
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 30, 2020
* [maps] clean up maps app state * remove time, query and refreshConfig from react state * clean up * move getInitialLayersFromUrlParam out of MapsAppView * clean up _updateFromGlobalState to just call _onQueryChange * inline _getAppStateFilters * tslint cleanup and fix refresh config * fix functional test * fix functional tests take 2 * review feedback * fix timing issue by not providing default query context value from props * minor cleanup Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Jul 30, 2020
* [maps] clean up maps app state * remove time, query and refreshConfig from react state * clean up * move getInitialLayersFromUrlParam out of MapsAppView * clean up _updateFromGlobalState to just call _onQueryChange * inline _getAppStateFilters * tslint cleanup and fix refresh config * fix functional test * fix functional tests take 2 * review feedback * fix timing issue by not providing default query context value from props * minor cleanup Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up
MapsAppViewstate by removingtime,query,refreshConfig, andprevIndexPatternIds.time,query, andrefreshConfigis not needed in state since its stored in redux.prevIndexPatternIdsis moved to an instance member since its used to track changes and does not effect rendering.