Skip to content

[7.x] [maps] clean up maps app state (#73337)#73810

Merged
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-73337
Jul 30, 2020
Merged

[7.x] [maps] clean up maps app state (#73337)#73810
nreese merged 1 commit intoelastic:7.xfrom
nreese:backport/7.x/pr-73337

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Jul 30, 2020

Backports the following commits to 7.x:

* [maps] clean up maps app state

* remove time, query and refreshConfig from react state

* clean up

* move getInitialLayersFromUrlParam out of MapsAppView

* clean up _updateFromGlobalState to just call _onQueryChange

* inline _getAppStateFilters

* tslint cleanup and fix refresh config

* fix functional test

* fix functional tests take 2

* review feedback

* fix timing issue by not providing default query context value from props

* minor cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@nreese nreese added the backport This PR is a backport of another PR label Jul 30, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.8MB -3.4KB 3.8MB

page load bundle size

id value diff baseline
maps 284.0KB -491.0B 284.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit b393516 into elastic:7.x Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants