Skip to content

[add data] edit pipeline#7193

Closed
BigFunger wants to merge 4 commits intoelastic:feature/ingestfrom
BigFunger:add-data-edit-pipeline
Closed

[add data] edit pipeline#7193
BigFunger wants to merge 4 commits intoelastic:feature/ingestfrom
BigFunger:add-data-edit-pipeline

Conversation

@BigFunger
Copy link
Copy Markdown
Contributor

@BigFunger BigFunger commented May 12, 2016 •
edited
Loading

Prototype Only

  • Adds converters for es_to_kibana for all processors
  • Adds pipelines endpoint for listing all pipelines, and loading an existing pipeline
  • Adds initial step to add data wizard that allows the user to select an existing pipeline instead of creating a new one. This step is very rough, and isn't even necessarily how I would design it. It's included to illustrate the load functionality
  • Moved the logic that initializes a processor with the data from another processor. This is used when loading from storage, and when returning to the pipeline step from later steps in the wizard. This logic used to live in the pipeline addExisting function, I've moved it into the constructor of each processor. Each processor now only loads the data defined in it's model.

Note: I did not modify the later steps of the wizard that would allow the modified pipeline to be saved over an older version of itself. This functionality was initially written by @Bargs, and I would like to discuss how that would work first.

I think the changes made to the processors is worthy of it's own pull, and could go in independent of the 'load saved pipeline' functionality.

@BigFunger BigFunger added review discuss Feature:Add Data Add Data and sample data feature on Home labels May 12, 2016
@BigFunger BigFunger changed the title Add data edit pipeline [add data] edit pipeline May 12, 2016
Bargs
Bargs reviewed May 12, 2016
View reviewed changes
...public/settings/sections/indices/add_data_steps/pipeline_setup/processors/date/view_model.js
this.timezone = 'Etc/UTC';
this.locale = 'ENGLISH';
this.customFormat = '';
_.assign(this,
Copy link
Copy Markdown
Contributor

@Bargs Bargs May 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but it might make intentions more clear if you use _.defaults here instead of _.assign since you're basically setting defaults.

@Bargs
Copy link
Copy Markdown
Contributor

Bargs commented May 13, 2016

Overall the approach looks solid. I added a few inline comments. Since it's just a prototype I tried to only focus on higher level details for now (but as you can tell I couldn't help myself occasionally, sorry :) )

A few other thoughts:

  • Maybe converters should contain methods for converting both ways instead of splitting them into separate modules? Could be fromKibana and toKibana maybe? I'm just thinking it might make things easier to understand.
  • Regardless of how the pipeline selection ultimately gets implemented, I think the pipeline-setup directive should probably be responsible for initiating the conversion of the Kibana API pipeline into a view-model Pipeline. Outside code shouldn't have to know how to use the view-model classes specific to this directive. This basically goes back to my desire to pass pure model objects to and from these wizard step directives. Maybe with some additional thought we can make it work.
  • I think we're already on the same page here, but we'll need to talk to Jurgen and maybe Court and Rashid after they've decided how the new "management" sections are going to be organized before we know exactly how this edit capability is going to be exposed.

@Bargs Bargs assigned BigFunger and unassigned Bargs May 13, 2016
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Oct 8, 2016

@BigFunger Is this PR still relevant?

@BigFunger BigFunger closed this Nov 18, 2016
jbudz pushed a commit that referenced this pull request Sep 27, 2023
@cee-chen @patrykkopycinski @janmonschke
Upgrade EUI to v88.5.0 (#166868)
581b30b 
`v88.3.0`⏩`v88.5.0`

closes #151514

---

## [`88.5.0`](https://github.com/elastic/eui/tree/v88.5.0)

- Updated `EuiCallOut` with a new `onDismiss` prop
([#7156](elastic/eui#7156))
- Added a new `renderCustomToolbar` prop to `EuiDataGrid`, which allows
custom rendering of the toolbar.
([#7190](elastic/eui#7190))
- Added a new `allowResetButton` prop to
`toolbarVisibility.showDisplaySelector` of `EuiDataGrid`, which allows
hiding the "Reset to default" button from the display settings popover.
([#7190](elastic/eui#7190))
- Added a new `additionalDisplaySettings` prop to
`toolbarVisibility.showDisplaySelector` of `EuiDataGrid`, which allows
rendering extra settings inside the display settings popover.
([#7190](elastic/eui#7190))
- Updated `EuiDataGrid`'s toolbar display settings button icon
([#7190](elastic/eui#7190))
- Updated `EuiTextTruncate` with significantly improved iteration
performance. Removed `measurementRenderAPI` prop, as `EuiTextTruncation`
now only uses more performant canvas render API
([#7210](elastic/eui#7210))
- Updated `EuiPopover` with a new configurable `repositionToCrossAxis`
prop ([#7211](elastic/eui#7211))
- Updated `EuiDatePicker` to support `compressed` input styling
([#7218](elastic/eui#7218))
- Added `gradient` and `palette` icon glyphs.
([#7220](elastic/eui#7220))

**Bug fixes**

- Fixed `EuiPopover`'s missing animations on popover close
([#7211](elastic/eui#7211))
- Fixed `EuiInputPopover` anchoring to the wrong side and missing
shadows on smaller screens
([#7211](elastic/eui#7211))
- Fixed `EuiSuperDatePicker` icon spacing on the quick select button
([#7217](elastic/eui#7217))
- Fixed a missing type in `EuiMarkdownEditor`'s default processing
plugins ([#7221](elastic/eui#7221))


## [`88.4.1`](https://github.com/elastic/eui/tree/v88.4.1)

**Bug fixes**

- Fixed missing `className`s on `EuiTextTruncate`
([#7212](elastic/eui#7212))
- Fixed `title`s on `EuiComboBox` dropdown options to always be present
([#7212](elastic/eui#7212))
- Fixed `EuiComboBox` truncation issues when search is an empty space
([#7212](elastic/eui#7212))

## [`88.4.0`](https://github.com/elastic/eui/tree/v88.4.0)

- Updated `EuiComboBox` to allow configuring text truncation behavior
via `truncationProps`. These props can be set on the entire combobox as
well as on on individual dropdown options.
([#7028](elastic/eui#7028))
- Updated `EuiInMemoryTable` with a new `searchFormat` prop (defaults to
`eql`). When setting this prop to `text`, the built-in search bar will
ignore EQL syntax and allow searching for plain strings with special
characters and symbols.
([#7175](elastic/eui#7175))

**Bug fixes**

- `EuiComboBox` now always shows the highlighted search text, even on
truncated text ([#7028](elastic/eui#7028))
- Fixed missing i18n in `EuiSearchBar`'s default placeholder and
aria-label text ([#7175](elastic/eui#7175))
- Fixed the inline compressed styles of `EuiDescriptionListTitle` to use
a taller line-height for readability
([#7185](elastic/eui#7185))
- Fixed `EuiComboBox` to correctly truncate selected items when
displayed as pills and plain text
([#7193](elastic/eui#7193))

**Accessibility**

- Added `aria-current` attribute to `EuiTablePagination`
([#7186](elastic/eui#7186))

**CSS-in-JS conversions**

- Converted `EuiDroppable` and `EuiDraggable` to Emotion; Removed
`$euiDragAndDropSpacing` Sass variables
([#7187](elastic/eui#7187))

---------

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
Co-authored-by: Thomas Watson <watson@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BigFunger BigFunger

Labels

discuss Feature:Add Data Add Data and sample data feature on Home

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BigFunger @Bargs @epixa