Skip to content

Upgrade EUI to v88.5.0#166868

Merged
jbudz merged 24 commits intoelastic:mainfrom
cee-chen:eui-v88.4.x
Sep 27, 2023
Merged

Upgrade EUI to v88.5.0#166868
jbudz merged 24 commits intoelastic:mainfrom
cee-chen:eui-v88.4.x

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Sep 20, 2023 •
edited
Loading

v88.3.0⏩v88.5.0

closes #151514

88.5.0

  • Updated EuiCallOut with a new onDismiss prop (#7156)
  • Added a new renderCustomToolbar prop to EuiDataGrid, which allows custom rendering of the toolbar. (#7190)
  • Added a new allowResetButton prop to toolbarVisibility.showDisplaySelector of EuiDataGrid, which allows hiding the "Reset to default" button from the display settings popover. (#7190)
  • Added a new additionalDisplaySettings prop to toolbarVisibility.showDisplaySelector of EuiDataGrid, which allows rendering extra settings inside the display settings popover. (#7190)
  • Updated EuiDataGrid's toolbar display settings button icon (#7190)
  • Updated EuiTextTruncate with significantly improved iteration performance. Removed measurementRenderAPI prop, as EuiTextTruncation now only uses more performant canvas render API (#7210)
  • Updated EuiPopover with a new configurable repositionToCrossAxis prop (#7211)
  • Updated EuiDatePicker to support compressed input styling (#7218)
  • Added gradient and palette icon glyphs. (#7220)

Bug fixes

  • Fixed EuiPopover's missing animations on popover close (#7211)
  • Fixed EuiInputPopover anchoring to the wrong side and missing shadows on smaller screens (#7211)
  • Fixed EuiSuperDatePicker icon spacing on the quick select button (#7217)
  • Fixed a missing type in EuiMarkdownEditor's default processing plugins (#7221)

88.4.1

Bug fixes

  • Fixed missing classNames on EuiTextTruncate (#7212)
  • Fixed titles on EuiComboBox dropdown options to always be present (#7212)
  • Fixed EuiComboBox truncation issues when search is an empty space (#7212)

88.4.0

  • Updated EuiComboBox to allow configuring text truncation behavior via truncationProps. These props can be set on the entire combobox as well as on on individual dropdown options. (#7028)
  • Updated EuiInMemoryTable with a new searchFormat prop (defaults to eql). When setting this prop to text, the built-in search bar will ignore EQL syntax and allow searching for plain strings with special characters and symbols. (#7175)

Bug fixes

  • EuiComboBox now always shows the highlighted search text, even on truncated text (#7028)
  • Fixed missing i18n in EuiSearchBar's default placeholder and aria-label text (#7175)
  • Fixed the inline compressed styles of EuiDescriptionListTitle to use a taller line-height for readability (#7185)
  • Fixed EuiComboBox to correctly truncate selected items when displayed as pills and plain text (#7193)

Accessibility

  • Added aria-current attribute to EuiTablePagination (#7186)

CSS-in-JS conversions

  • Converted EuiDroppable and EuiDraggable to Emotion; Removed $euiDragAndDropSpacing Sass variables (#7187)

@cee-chen cee-chen force-pushed the eui-v88.4.x branch 10 times, most recently from f22a7ab to 4d1458e Compare September 21, 2023 18:25
@cee-chen cee-chen changed the title Upgrade EUI to v88.4.0 Upgrade EUI to v88.4.1 Sep 21, 2023
@cee-chen cee-chen marked this pull request as ready for review September 21, 2023 20:29
@cee-chen cee-chen requested review from a team as code owners September 21, 2023 20:29
@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.11.0 labels Sep 21, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 21, 2023

Pinging @elastic/eui-team (EUI)

@cee-chen
Copy link
Copy Markdown
Contributor Author

cee-chen commented Sep 21, 2023

👋 Marking as ready for review as Jest and FTR tests are passing, and I'm fairly confident the Cypress failures above aren't related to EUI changes (as always, let me know if that assumption is incorrect!)

Most changes in this upgrade are related to EuiComboBox and EuiDraggable/EuiDroppable (although there shouldn't be any breaking changes around them). Please feel free to QA your usages of these components and alert us if you find any regressions!

@dej611 dej611 mentioned this pull request Sep 22, 2023
Open
@1Copenut 1Copenut mentioned this pull request Sep 22, 2023
Closed
mashhurs
mashhurs approved these changes Sep 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Logstash!

@patrykkopycinski patrykkopycinski requested a review from a team as a code owner September 26, 2023 19:45
@patrykkopycinski patrykkopycinski requested a review from a team as a code owner September 26, 2023 20:39
@patrykkopycinski
Copy link
Copy Markdown
Contributor

patrykkopycinski commented Sep 27, 2023

@watson can we force merge this as well?

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Sep 27, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #26 / core plugins rendering service exposes plugin config settings to authenticated users
  • [job] [logs] FTR Configs #21 / visualize app visual builder metric Top Hit aggregation should show correct data for string type field

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fileUpload 957.5KB 957.5KB -1.0B
maps 2.8MB 2.8MB -1.0B
total -2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 367.7KB 368.3KB +625.0B
kbnUiSharedDeps-css 278.7KB 275.4KB -3.3KB
kbnUiSharedDeps-npmDll 6.2MB 6.3MB +4.5KB
total +1.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jeramysoucy
jeramysoucy approved these changes Sep 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jeramysoucy jeramysoucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppEx Security changes LGTM!

@jbudz
Copy link
Copy Markdown
Contributor

jbudz commented Sep 27, 2023

osquery type fixes will be addressed at #167428.

@jbudz jbudz merged commit 581b30b into elastic:main Sep 27, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 27, 2023
@cee-chen cee-chen deleted the eui-v88.4.x branch September 28, 2023 17:51
@achyutjhunjhunwala achyutjhunjhunwala mentioned this pull request Sep 29, 2023
Merged
achyutjhunjhunwala added a commit that referenced this pull request Sep 29, 2023
@achyutjhunjhunwala
[APM] Fix cypress memory issue due to log panel (#167623)
2047a55 
## Summary

Recent [EUI bump](#166868) from
v88.3.0 to v88.5.0 increased the memory usage significantly. Due to
which Cypress Tests started failing due to browser crashing with memory
limits. EUI team has been informed about this.

As reverting EUI is not a simple change, disabling the Cypress Log panel
solves the problem for now. Details can be found
[here](cypress-io/cypress#27415 (comment))

This brings change to how we run the Cypress Test in Head Mode

## Before


![image](https://github.com/elastic/kibana/assets/7416358/12a92c64-2e31-4423-8e8a-94a311757bd7)

## After

![image
(1)](https://github.com/elastic/kibana/assets/7416358/d3a522c9-66e8-497c-b046-32a6c866b600)
michaelolo24
michaelolo24 reviewed Oct 25, 2023
View reviewed changes
...test/security_solution_cypress/cypress/e2e/investigations/alerts/changing_alert_status.cy.ts
});

it('Open one alert when more than one closed alerts are selected', () => {
it.skip('Open one alert when more than one closed alerts are selected', () => {
Copy link
Copy Markdown
Contributor

@michaelolo24 michaelolo24 Oct 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrykkopycinski - why were these tests skipped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelolo24 michaelolo24 michaelolo24 left review comments

@rudolf rudolf rudolf approved these changes

@jbudz jbudz jbudz approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@janmonschke janmonschke janmonschke approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@spong spong spong approved these changes

@rylnd rylnd rylnd approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@markov00 markov00 markov00 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jennypavlova jennypavlova jennypavlova approved these changes

@nreese nreese nreese approved these changes

@jcger jcger jcger approved these changes

@davismcphee davismcphee davismcphee approved these changes

@mashhurs mashhurs mashhurs approved these changes

@jeramysoucy jeramysoucy jeramysoucy approved these changes

@nikitaindik nikitaindik Awaiting requested review from nikitaindik nikitaindik was automatically assigned from elastic/security-detection-rule-management

@MadameSheema MadameSheema Awaiting requested review from MadameSheema

@oatkiller oatkiller Awaiting requested review from oatkiller

@maximpn maximpn Awaiting requested review from maximpn

@banderror banderror Awaiting requested review from banderror

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl was automatically assigned from elastic/security-defend-workflows

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(Accessibility) Rows per page flyout on data grid should announce the selected option to screen readers