[SECURITY] Alerts back to Detections#71142
Conversation
|
Pinging @elastic/siem (Team:SIEM) |
spong
left a comment
There was a problem hiding this comment.
Checked out, tested locally and LGTM! 👍 Thank you much for the re-re-name @XavierM 🙂 🚀 🎉
In testing I did find two little issues, but nothing to hold this up.
- We'll want the breadcrumbs to match the URL right? So
Security / Detections / Rulesthen?
- This still appears to be an issue: #70659. When testing actions with the
{{context.results_link}}variable this was what I was seeing. Just looks like we've got an extradetectionsin there.
http://localhost:5601/app/security/detections#/detections/rules/id/3a2f06c3-7125-466c-a14b-1d0d0c0c4e75?timerange=(global:(linkTo:!(timeline),timerange:(from:1594264276585,kind:absolute,to:1594264336585)),timeline:(linkTo:!(global),timerange:(from:1594264276585,kind:absolute,to:1594264336585)))
* part I to rename alerts back to detections * part 2 to rename alerts to detections * update imports * fix layout container event type * Detection Alerts * fix type/UT/cypress
| 'xpack.securitySolution.timeline.searchOrFilter.eventTypeDetectionAlertsEvent', | ||
| { | ||
| defaultMessage: 'Alert events', | ||
| defaultMessage: 'Detection Alerts', |
There was a problem hiding this comment.
Timeline changes looks good! Thanks for the extra width. 🙂 Curious if we'll want alerts lowercase to match events though? cc @lindseypoli @marrasherrier
* master: (39 commits) [APM] Add warning to notify user about legacy ML jobs (elastic#71030) updates consumer to siem (elastic#71117) Index pattern creation flow - fix spelling (elastic#71192) [Security Solution][Endpoint] User Manifest Cleanup + Artifact Compression (elastic#70759) [SECURITY] Rearrange rule name's column in Alert Table (elastic#71020) [SECURITY] Alerts back to Detections (elastic#71142) [Security Solution][Exceptions Builder] - Fixes operator selection bug (elastic#71178) [SIEM][Detection Engine] Speeds up value list imports by enabling streaming of files. [APM] Update ML job ID in data telemetry tasks (elastic#71044) [Resolver] Remove `currentPanelView` selector (elastic#71154) add meta.managed to index templates (elastic#71135) Clarify trial subscription levels (elastic#70900) [Security Solution] fix panel links (elastic#71148) skip flaky suite (elastic#69632) skip suite failing ES Promotion (elastic#71018) [ML] DF Analytics: add results field to wizard and show regression stats (elastic#70893) [SIEM] update wordings (elastic#71119) [SECURITY SOLUTION] Rename to hosts and administration (elastic#70913) [ML] Improvements for urlState hook. (elastic#70576) Removing uptime guide (elastic#71124) ...
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos·js.context app context view for date_nanos displays predessors - anchor - successors in right orderStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos·js.context app context view for date_nanos displays predessors - anchor - successors in right orderStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_filter_bar·js.dashboard app using current data dashboard filter bar filter editor field list shows index pattern of vis when one is addedStandard OutStack Traceand 4 more failures, only showing the first 3. Build metrics
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |



Summary
here where the discussion is https://github.com/elastic/endpoint-app-team/issues/412#issuecomment-652028915