[ML] DF Analytics: add results field to wizard and show regression stats#70893
Merged
alvarezmelissa87 merged 8 commits intoelastic:masterfrom Jul 8, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
60 tasks
...me_analytics/pages/analytics_exploration/components/regression_exploration/evaluate_stat.tsx
Outdated
Show resolved
Hide resolved
...me_analytics/pages/analytics_exploration/components/regression_exploration/evaluate_stat.tsx
Outdated
Show resolved
Hide resolved
.../data_frame_analytics/pages/analytics_creation/components/details_step/details_step_form.tsx
Outdated
Show resolved
Hide resolved
...n/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/reducer.ts
Outdated
Show resolved
Hide resolved
8fa38ad to
9ae28f1
Compare
jgowdyelastic
approved these changes
Jul 8, 2020
Member
jgowdyelastic
left a comment
There was a problem hiding this comment.
Added a couple of comments, but generally LGTM
Member
There was a problem hiding this comment.
rather than using a for..of, this loop could be written as:
Object.entries(response.regression).forEach(([statType, { value }]) => {
results[statType as keyof RegressionEvaluteExtractedResponse] = value.toPrecision(
DEFAULT_SIG_FIGS
);
});
but i don't know whether it's more readable :)
Contributor
Author
There was a problem hiding this comment.
I prefer the more readable for loop option since in this case there are only 4 properties we're checking for.
peteharverson
approved these changes
Jul 8, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest edits and LGTM (apart from the Evalute typo!).
9ae28f1 to
8559b4b
Compare
Contributor
💛 Build succeeded, but was flaky
Test FailuresFirefox UI Functional Tests.test/functional/apps/visualize/_tsvb_chart·ts.visualize app visual builder metric should populate fields for basic functionsStandard OutStack TraceBuild metrics
History
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Jul 8, 2020
…ats (elastic#70893) * add results_field input in form. handle in cloning and editor * update regression evaluate metrics * add additional reg evaluation stats to expanded row and result panel * update jest test * resultsField: check for only spaces string in editor and form * update getValuesFromResult to be less repetitive * update types * fix type name typo
alvarezmelissa87
added a commit
that referenced
this pull request
Jul 9, 2020
…ats (#70893) (#71161) * add results_field input in form. handle in cloning and editor * update regression evaluate metrics * add additional reg evaluation stats to expanded row and result panel * update jest test * resultsField: check for only spaces string in editor and form * update getValuesFromResult to be less repetitive * update types * fix type name typo
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 9, 2020
* master: (39 commits) [APM] Add warning to notify user about legacy ML jobs (elastic#71030) updates consumer to siem (elastic#71117) Index pattern creation flow - fix spelling (elastic#71192) [Security Solution][Endpoint] User Manifest Cleanup + Artifact Compression (elastic#70759) [SECURITY] Rearrange rule name's column in Alert Table (elastic#71020) [SECURITY] Alerts back to Detections (elastic#71142) [Security Solution][Exceptions Builder] - Fixes operator selection bug (elastic#71178) [SIEM][Detection Engine] Speeds up value list imports by enabling streaming of files. [APM] Update ML job ID in data telemetry tasks (elastic#71044) [Resolver] Remove `currentPanelView` selector (elastic#71154) add meta.managed to index templates (elastic#71135) Clarify trial subscription levels (elastic#70900) [Security Solution] fix panel links (elastic#71148) skip flaky suite (elastic#69632) skip suite failing ES Promotion (elastic#71018) [ML] DF Analytics: add results field to wizard and show regression stats (elastic#70893) [SIEM] update wordings (elastic#71119) [SECURITY SOLUTION] Rename to hosts and administration (elastic#70913) [ML] Improvements for urlState hook. (elastic#70576) Removing uptime guide (elastic#71124) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #66661
This PR:
results_fieldin job wizardChecklist
Delete any items that are not applicable to this PR.