add short sleep before clicking Remove on sample data#71104
Merged
LeeDr merged 5 commits intoelastic:masterfrom Jul 15, 2020
Merged
add short sleep before clicking Remove on sample data#71104LeeDr merged 5 commits intoelastic:masterfrom
LeeDr merged 5 commits intoelastic:masterfrom
Conversation
Author
|
@elasticmachine merge upstream |
Author
|
The last run failed because I put |
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-core-ui (Team:Core UI) |
myasonik
approved these changes
Jul 14, 2020
Contributor
myasonik
left a comment
There was a problem hiding this comment.
LGTM!
It maybe isn't perfect but this seems like a good enough solution to merge
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Jul 15, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Jul 15, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 15, 2020
* master: [Form lib] Memoize form hook object and fix hook array deps (elastic#71237) [uiActions] Support emitting nested triggers and actions (elastic#70602) add short sleep before clicking Remove on sample data (elastic#71104) Fixed the beta badge layout. (elastic#71835) Restores task for downloading Chromium builds (elastic#71749) [logging] Format new platform json logging to ECS (elastic#71138) add policy details and update SO limit requests (elastic#71789) Convert vis_type_vega to Typescript (elastic#68915) [ML] Fix UI Actions context menu positioning for the Anomaly Swim Lane (elastic#71839)
LeeDr
pushed a commit
that referenced
this pull request
Jul 15, 2020
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Jul 15, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
LeeDr
pushed a commit
that referenced
this pull request
Jul 15, 2020
LeeDr
pushed a commit
that referenced
this pull request
Jul 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #65949
Actually I wouldn't call it a "fix" but more of a work-around. Screenshots from intermittent failures on removing sample data show the "Remove" button as if it had not been clicked but the logs indicate that it found and clicked it.
My theory is that 2 checks have to happen when the sample data page loads, for each set of sample data;
I don't know the order that those checks happen in (and maybe other checks) vs when the "Remove" button is rendered, but there could be a small timing window where the button is visible and enabled but actually won't remove the same data.
This PR attempts to test that case by adding about a 1 second sleep (I use 1010ms to make it easier to find something that might be unique in the logs) between the time we find the button is enabled and when we click it.
Alternatively we could change the removeSampleDataSet to retry clicking the button until we find it changed to disabled. But that feels worse to me, as far as masking a potential code bug, then adding a small delay before a single try.
Checklist
Delete any items that are not applicable to this PR.
For maintainers