Convert vis_type_vega to Typescript#68915
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
|
Sure @flash1293 :) |
|
Jenkins, test this |
stratoula
left a comment
There was a problem hiding this comment.
I have tested it locally on Safari and FF and the functionality is not broken. I think that a good job has been done to type the majority of the code. Thank you @ashikmeerankutty for taking care of it 🍪
flash1293
left a comment
There was a problem hiding this comment.
Reviewed the code again and this LGTM. Thanks again for going through this, great improvement for the Kibana code base!
|
@elasticmachine merge upstream |
|
7.9 will be branched off today or tomorrow, I will hold this PR back till this is done, so the change will go into 7.10 I'm doing this so we have another minor of testing whether anything broke - as this is not adding any features, there's no benefit to squeezing it into 7.9 |
|
@elasticmachine merge upstream |
|
Jenkins, test this. |
|
@elasticmachine merge upstream |
|
Jenkins, this this. |
|
Jenkins test, this. |
💚 Build SucceededBuild metricsasync chunks size
miscellaneous assets size
page load bundle size
History
To update your PR or re-run it, just comment with: |
* master: [Form lib] Memoize form hook object and fix hook array deps (elastic#71237) [uiActions] Support emitting nested triggers and actions (elastic#70602) add short sleep before clicking Remove on sample data (elastic#71104) Fixed the beta badge layout. (elastic#71835) Restores task for downloading Chromium builds (elastic#71749) [logging] Format new platform json logging to ECS (elastic#71138) add policy details and update SO limit requests (elastic#71789) Convert vis_type_vega to Typescript (elastic#68915) [ML] Fix UI Actions context menu positioning for the Anomaly Swim Lane (elastic#71839)
Summary
Makes progress on #65839
datain vis_type_vega to TypescriptChecklist
Delete any items that are not applicable to this PR.
- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibility- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser- [ ] This was checked for cross-browser compatibility, including a check against IE11For maintainers