Fixes special clicks and 3rd party icon sizes in nav by myasonik · Pull Request #69767 · elastic/kibana

myasonik · 2020-06-23T23:36:45Z

Summary

43f60ef fixes #69691
Instead of trying to correctly size an image in the nav, using EuiIcon for 3rd party icons (same as our icons use)

ddedb8e fixes #69656
Doesn't close the nav for modified clicks (such as cmd+click on mac to open in a new tab)

elasticmachine · 2020-06-23T23:36:47Z

Pinging @elastic/kibana-core-ui (Team:Core UI)

src/core/public/chrome/ui/header/nav_link.tsx

kibanamachine · 2020-06-24T17:02:21Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 6a7d590
Flaky suites:
- xpack-kibana-ciGroup1

Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/basic/tests/find_statuses·ts.detection engine api security and spaces enabled find_statuses "after each" hook for "should return a single rule status when a single rule is loaded from a find status with defaults added"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/69632

[00:00:00]       │
[00:00:00]         └-: detection engine api security and spaces enabled
[00:00:00]           └-> "before all" hook
[00:02:04]           └-: find_statuses
[00:02:04]             └-> "before all" hook
[00:02:04]             └-> should return an empty find statuses body correctly if no statuses are loaded
[00:02:04]               └-> "before each" hook: global before each
[00:02:04]               └-> "before each" hook
[00:02:04]                 │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] adding index lifecycle policy [.siem-signals-default]
[00:02:04]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:02:05]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1], mappings [_doc]
[00:02:05]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:02:05]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:02:05]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:02:05]               └- ✓ pass  (17ms) "detection engine api security and spaces enabled find_statuses should return an empty find statuses body correctly if no statuses are loaded"
[00:02:05]             └-> "after each" hook
[00:02:05]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] [.siem-signals-default-000001/1Z_MU_SWSnGWvS8OXwRlIw] deleting index
[00:02:05]               │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] removing template [.siem-signals-default]
[00:02:05]             └-> should return a single rule status when a single rule is loaded from a find status with defaults added
[00:02:05]               └-> "before each" hook: global before each
[00:02:05]               └-> "before each" hook
[00:02:05]                 │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] adding index lifecycle policy [.siem-signals-default]
[00:02:05]                 │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:02:05]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1], mappings [_doc]
[00:02:05]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:02:05]                 │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] in policy [.siem-signals-default]
[00:02:05]               │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"wait-for-indexing-complete"}] to [{"phase":"hot","action":"unfollow","name":"wait-for-follow-shard-tasks"}] in policy [.siem-signals-default]
[00:02:07]               └- ✓ pass  (2.4s) "detection engine api security and spaces enabled find_statuses should return a single rule status when a single rule is loaded from a find status with defaults added"
[00:02:07]             └-> "after each" hook
[00:02:07]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] [.siem-signals-default-000001/KpDIcunHQKuRs3s4597etQ] deleting index
[00:02:07]               │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xl-1593011061944176811] removing template [.siem-signals-default]
[00:02:08]               └- ✖ fail: "detection engine api security and spaces enabled find_statuses "after each" hook for "should return a single rule status when a single rule is loaded from a find status with defaults added""
[00:02:08]               │

Stack Trace

{ ResponseError: Response Error
    at IncomingMessage.response.on (/dev/shm/workspace/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:287:25)
    at endReadableNT (_stream_readable.js:1145:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)
  name: 'ResponseError',
  meta:
   { body:
      { took: 5,
        timed_out: false,
        total: 1,
        deleted: 0,
        batches: 1,
        version_conflicts: 1,
        noops: 0,
        retries: [Object],
        throttled_millis: 0,
        requests_per_second: -1,
        throttled_until_millis: 0,
        failures: [Array] },
     statusCode: 409,
     headers:
      { 'content-type': 'application/json; charset=UTF-8',
        'content-length': '649' },
     warnings: null,
     meta:
      { context: null,
        request: [Object],
        name: 'elasticsearch-js',
        connection: [Object],
        attempts: 0,
        aborted: false } } }

Build metrics

✅ unchanged

History

💚 Build #55767 succeeded ddedb8e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (90 commits) [Encrypted Saved Objects] Adds support for migrations in ESO (elastic#69513) [SIEM] Replace WithSource with useWithSource hook (elastic#68722) [Endpoint]EMT-451: add ability to filter endpoint metadata based on presence of unenrolled events (elastic#69708) rename old siem kibana config to securitySolution (elastic#69874) Remove unused Resolver code (elastic#69914) [Observability] Fixing dynamic return type based on the appName (elastic#69894) [SECURITY SOLUTION][INGEST] Task/endpoint list tests (elastic#69419) Fixes special clicks and 3rd party icon sizes in nav (elastic#69767) [APM] Catch annotations index permission error and log warning (elastic#69881) [Endpoint][Ingest Manager] minor code cleanup (elastic#69844) [Logs UI] Logs ui context menu (elastic#69915) Index pattern serialize and de-serialize (elastic#68844) [QA] Unskip functional tests (elastic#69760) [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715) Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863) PR: Provide limit warnings to user when API limits are reached. (elastic#69590) [Maps] Remove broken button (elastic#69853) Makes usage collection methods available on start (elastic#69836) [SIEM][CASE] Improve Jira's labelling (elastic#69892) [Logs UI] Access ML via the programmatic plugin API (elastic#68905) ...

* master: [Encrypted Saved Objects] Adds support for migrations in ESO (elastic#69513) [SIEM] Replace WithSource with useWithSource hook (elastic#68722) [Endpoint]EMT-451: add ability to filter endpoint metadata based on presence of unenrolled events (elastic#69708) rename old siem kibana config to securitySolution (elastic#69874) Remove unused Resolver code (elastic#69914) [Observability] Fixing dynamic return type based on the appName (elastic#69894) [SECURITY SOLUTION][INGEST] Task/endpoint list tests (elastic#69419) Fixes special clicks and 3rd party icon sizes in nav (elastic#69767) [APM] Catch annotations index permission error and log warning (elastic#69881) [Endpoint][Ingest Manager] minor code cleanup (elastic#69844) [Logs UI] Logs ui context menu (elastic#69915) Index pattern serialize and de-serialize (elastic#68844)

Michail Yasonik added 2 commits June 23, 2020 15:04

Correctly size legacy nav 3rd party icons

43f60ef

keep nav open when modifier clicks

ddedb8e

myasonik added release_note:fix v8.0.0 REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.9.0 labels Jun 23, 2020

myasonik requested a review from a team as a code owner June 23, 2020 23:36

pgayvallet reviewed Jun 24, 2020

View reviewed changes

src/core/public/chrome/ui/header/nav_link.tsx Show resolved Hide resolved

Michail Yasonik added 2 commits June 24, 2020 11:03

rename isModified to isModifiedOrPrevented

8d2e0f7

Merge remote-tracking branch 'upstream/master' into fix/nav-bugs

6a7d590

pgayvallet approved these changes Jun 25, 2020

View reviewed changes

myasonik merged commit 1d60c35 into elastic:master Jun 25, 2020

myasonik deleted the fix/nav-bugs branch June 25, 2020 15:06

myasonik mentioned this pull request Jun 25, 2020

[7.x] Fixes special clicks and 3rd party icon sizes in nav (#69767) #69950

Merged

myasonik pushed a commit that referenced this pull request Jun 25, 2020

Fixes special clicks and 3rd party icon sizes in nav (#69767) (#69950)

08ced76

Desvelao mentioned this pull request Sep 17, 2020

Bugs found during testing of 4.0.0 - 7.8.0 wazuh/wazuh-dashboard-plugins#2457

Closed

27 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes special clicks and 3rd party icon sizes in nav#69767

Fixes special clicks and 3rd party icon sizes in nav#69767
myasonik merged 4 commits intoelastic:masterfrom
myasonik:fix/nav-bugs

myasonik commented Jun 23, 2020

Uh oh!

elasticmachine commented Jun 23, 2020

Uh oh!

Uh oh!

kibanamachine commented Jun 24, 2020

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

myasonik commented Jun 23, 2020

Summary

Uh oh!

elasticmachine commented Jun 23, 2020

Uh oh!

Uh oh!

kibanamachine commented Jun 24, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Build metrics

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants