[SECURITY SOLUTION][INGEST] Task/endpoint list tests by parkiino · Pull Request #69419 · elastic/kibana

parkiino · 2020-06-17T16:14:49Z

Summary

Adds a functional test for [SECURITY SOLUTION] Task/endpoint details to fleet #68710 endpoint details > fleet
Adds a functional test for https://github.com/elastic/endpoint-app-team/issues/382 to test the ingest > edit endpoint datasource > link to endpoint policy details
Fixes https://github.com/elastic/endpoint-app-team/issues/512

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…t-tests

elasticmachine · 2020-06-23T22:11:45Z

Pinging @elastic/ingest-management (Team:Ingest Management)

elasticmachine · 2020-06-23T22:12:10Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

kevinlog · 2020-06-23T22:30:51Z

x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts

    });

-    it('displays table data', async () => {
+    it.skip('displays table data', async () => {


is this intentional?

EDIT: or is this identified as the flaky test?

kevinlog · 2020-06-23T22:35:21Z

x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts


  // FLAKY: https://github.com/elastic/kibana/issues/63621
-  describe.skip('endpoint list', function () {
+  describe('endpoint list', function () {


did you run this a few times locally to make sure it's no longer flaky?

kevinlog · 2020-06-23T22:37:26Z

x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts

+        const hostDetailTitleInitial = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
+        // select the same host in the host list
+        await (await testSubjects.findAll('hostnameCellLink'))[1].click();
+        await sleep(500); // give page time to refresh and verify it did not change


this was being skipped, before right? sleep() in tests make me a bit nervous, just wanna make sure this is run enough times to ensure this isn't flaky

@kevinlog The entire suite is being skipped (see describe on line 17), so I think we're goo for now. @charlie-pichette will take care of fixing the flakiness

…t-tests

...tion/public/management/pages/policy/view/ingest_manager_integration/configure_datasource.tsx

paul-tavares · 2020-06-24T16:52:34Z

x-pack/test/common/services/index.ts


 export const services = {
  ...kibanaCommonServices,
+  supertest: kibanaApiIntegrationServices.supertest,


Did you make these changes or was it from a master merge?

If you did - would like to know why we had to change the common services. was this because the API tests needed supertest? even then - adding it here impacts everyone, so not sure we want to do it this way

it was a master merge. i just moved this file out of test/api_integrations/services and then imported this file into the test/api_integrations/services/index hopefully thats ok?

to clarify, i needed to add this import since the ingest manager service needs supertest after the merge from master. I moved the file from api_integration/services/ingest_manager to common/services/ingest_manager since api_integration is using ingest and so is security_solution_endpoint. i could also just add that import directly to the ingest_manager service file, if you think thats better

Thank you - now I understand. I guess for Endpoint UI Functional, we did not have to do that because we import the services from x-pack/test/functional/ which (my guess) is already brings that service in.
Anyway 🙏

paul-tavares · 2020-06-24T16:55:46Z

x-pack/test/security_solution_endpoint/apps/endpoint/endpoint_list.ts

+        const hostDetailTitleInitial = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
+        // select the same host in the host list
+        await (await testSubjects.findAll('hostnameCellLink'))[1].click();
+        await sleep(500); // give page time to refresh and verify it did not change


@kevinlog The entire suite is being skipped (see describe on line 17), so I think we're goo for now. @charlie-pichette will take care of fixing the flakiness

paul-tavares · 2020-06-24T17:02:53Z

x-pack/test/security_solution_endpoint/apps/endpoint/policy_details.ts

+        const agentId = policyInfo.agentConfig.id;
+        const datasourceId = policyInfo.datasource.id;
+
+        await pageObjects.common.navigateToApp('ingestManager', {


I think we spoke about this, and... I might be changing my mind 😃

I'm thinking that we should create a method in the ingest pageObjects we have (ingest_manager_create_datasource_page.ts) named

navigateToAgentConfigEditDatasource(agentConfigId, datasourceId)

and call it from here. It will make it easier to keep all ingest related pageObjects in one place, case these move over to Ingest at a later time ++ any future changes to URLs, etc.

x-pack/test/security_solution_endpoint/services/index.ts

kibanamachine · 2020-06-24T23:03:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 94e5db4

Build metrics

✅ unchanged

History

💚 Build #56009 succeeded 0307fb5
💔 Build #55947 failed ad77f5c
💛 Build #55800 was flaky d83bff2
💔 Build #55742 failed e15848b
💚 Build #54764 succeeded 55697cb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

paul-tavares

LGTM 🚢 🚀

🙏

endpoint func tests for endpoint details to ingest, edit datasource to policy, bug fix for security link

* master: (90 commits) [Encrypted Saved Objects] Adds support for migrations in ESO (elastic#69513) [SIEM] Replace WithSource with useWithSource hook (elastic#68722) [Endpoint]EMT-451: add ability to filter endpoint metadata based on presence of unenrolled events (elastic#69708) rename old siem kibana config to securitySolution (elastic#69874) Remove unused Resolver code (elastic#69914) [Observability] Fixing dynamic return type based on the appName (elastic#69894) [SECURITY SOLUTION][INGEST] Task/endpoint list tests (elastic#69419) Fixes special clicks and 3rd party icon sizes in nav (elastic#69767) [APM] Catch annotations index permission error and log warning (elastic#69881) [Endpoint][Ingest Manager] minor code cleanup (elastic#69844) [Logs UI] Logs ui context menu (elastic#69915) Index pattern serialize and de-serialize (elastic#68844) [QA] Unskip functional tests (elastic#69760) [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715) Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863) PR: Provide limit warnings to user when API limits are reached. (elastic#69590) [Maps] Remove broken button (elastic#69853) Makes usage collection methods available on start (elastic#69836) [SIEM][CASE] Improve Jira's labelling (elastic#69892) [Logs UI] Access ML via the programmatic plugin API (elastic#68905) ...

endpoint func tests for endpoint details to ingest, edit datasource to policy, bug fix for security link

* master: [Encrypted Saved Objects] Adds support for migrations in ESO (elastic#69513) [SIEM] Replace WithSource with useWithSource hook (elastic#68722) [Endpoint]EMT-451: add ability to filter endpoint metadata based on presence of unenrolled events (elastic#69708) rename old siem kibana config to securitySolution (elastic#69874) Remove unused Resolver code (elastic#69914) [Observability] Fixing dynamic return type based on the appName (elastic#69894) [SECURITY SOLUTION][INGEST] Task/endpoint list tests (elastic#69419) Fixes special clicks and 3rd party icon sizes in nav (elastic#69767) [APM] Catch annotations index permission error and log warning (elastic#69881) [Endpoint][Ingest Manager] minor code cleanup (elastic#69844) [Logs UI] Logs ui context menu (elastic#69915) Index pattern serialize and de-serialize (elastic#68844)

parkiino added 9 commits June 16, 2020 15:31

used new datastream archiver code

c04c006

remove the commented out code

e4ce3a1

test for link to fleet from endpoint details

55697cb

Merge remote-tracking branch 'upstream/master' into task/endpoint-lis…

474138c

…t-tests

Merge remote-tracking branch 'upstream/master' into task/endpoint-lis…

27cfc80

…t-tests

renames tests, uses ingestManager setup

531b98a

Merge remote-tracking branch 'upstream/master' into task/endpoint-lis…

b21c846

…t-tests

finished up all tests + bug fix for security link

d3b957a

Merge remote-tracking branch 'upstream/master' into task/endpoint-lis…

e15848b

…t-tests

parkiino marked this pull request as ready for review June 23, 2020 22:11

parkiino requested a review from a team as a code owner June 23, 2020 22:11

parkiino requested a review from a team June 23, 2020 22:11

parkiino requested a review from a team as a code owner June 23, 2020 22:11

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 23, 2020

parkiino added release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management v7.9.0 v8.0.0 labels Jun 23, 2020

kevinlog reviewed Jun 23, 2020

View reviewed changes

parkiino added 4 commits June 23, 2020 22:57

add import

397d264

skip flaky tests still

d83bff2

Merge remote-tracking branch 'upstream/master' into task/endpoint-lis…

ad77f5c

…t-tests

remove duplicate import

0307fb5

paul-tavares reviewed Jun 24, 2020

View reviewed changes

addressing paul's comments

94e5db4

paul-tavares approved these changes Jun 24, 2020

View reviewed changes

kevinlog approved these changes Jun 25, 2020

View reviewed changes

parkiino merged commit 1daa2f4 into elastic:master Jun 25, 2020

parkiino deleted the task/endpoint-list-tests branch June 25, 2020 15:10

parkiino mentioned this pull request Jun 25, 2020

[7.x] [SECURITY SOLUTION][INGEST] Task/endpoint list tests (#69419) #69951

Merged

parkiino added a commit to parkiino/kibana that referenced this pull request Jun 25, 2020

[SECURITY SOLUTION][INGEST] Task/endpoint list tests (elastic#69419)

9b9e322

endpoint func tests for endpoint details to ingest, edit datasource to policy, bug fix for security link

parkiino added a commit that referenced this pull request Jun 25, 2020

[SECURITY SOLUTION][INGEST] Task/endpoint list tests (#69419) (#69951)

aec4ca9

endpoint func tests for endpoint details to ingest, edit datasource to policy, bug fix for security link

Conversation

parkiino commented Jun 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jun 23, 2020

Uh oh!

elasticmachine commented Jun 23, 2020

Uh oh!

kevinlog Jun 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parkiino Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Jun 24, 2020

💚 Build Succeeded

Build metrics

History

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

parkiino commented Jun 17, 2020 •

edited

Loading

kevinlog Jun 23, 2020 •

edited

Loading

parkiino Jun 24, 2020 •

edited

Loading