Skip to content

[Uptime] Edit uptime alerts#68005

Merged
justinkambic merged 53 commits intoelastic:masterfrom
justinkambic:uptime_edit-alerts-ahead
Jun 8, 2020
Merged

[Uptime] Edit uptime alerts#68005
justinkambic merged 53 commits intoelastic:masterfrom
justinkambic:uptime_edit-alerts-ahead

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

@justinkambic justinkambic commented Jun 2, 2020 •
edited
Loading

Summary

Resolves elastic/uptime#179

Allows users to edit alerts they've previously created in the Uptime UI.

Something to note, old alerts will still work after this change, even though the underlying params have changed. I've added this callout to indicate to a user why some of their parameters aren't showing up:

image

Testing

There are a number of cases this PR seeks to cover, and the code is re-used in several different contexts, so it's important to thoroughly smoke test each case.

Creating an alert in Uptime

  • Create an alert from the Uptime UI with no filters or search pre-selected
  • Create an alert from Uptime with filters/search pre-selected. The values you were using in the app should auto-populate. The app won't stay in sync with the filters in the background today.

Creating an alert in the Management view

  • Create an alert and ensure filter values are populated.

Editing an alert in the Management view

  • Edit the alert, ensure that filters populate and that when you save the alert and re-edit, the values continue to appear.

Editing old alerts

  • Checkout 884704d or earlier and create an alert, then load this patch. Ensure that the alert you created can be edited, and continues to work properly after you save it.
  • You should see an "old alert" call out notifying you that some fields will not auto-populate.
  • Check that the "old alert" call out no longer appears if you open the alert after saving.

In all cases, add and remove filter values and searches to validate that these components behave as desired.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

justinkambic added 19 commits May 14, 2020 11:20
@justinkambic
Extract store creation to plugin start, add redux providers to alert …
c094dd9 
…registration.
@justinkambic
Update unit test.
6bb5519
@justinkambic
Move alert registration to setup function.
e5a1eb3
@justinkambic
Allow external editing of uptime client alert types.
03ec299
@justinkambic
Move alert initialization back to start.
bf16f6a
@justinkambic
Clean up interfaces for alert types.
c2ad6d0
@justinkambic
Add code that will work for settings link even outside uptime app.
f8e3c7e
@justinkambic
Merge branch 'master' into uptime_edit-alerts
4ced92e
@justinkambic
Create new atomic params type for status alerts.
47fe9cc
@justinkambic
Update executor params typing to support both alert params types.
f5cf3b5
@justinkambic
Update snapshot for alert factory function.
e414180
@justinkambic
Fix broken types and refresh snapshots.
68dec30
@justinkambic
Merge branch 'master' into uptime_edit-alerts
4c64d12
@justinkambic
Merge branch 'uptime_monitor-status-alert-params' into uptime_edit-al…
13594b7 
…erts-ahead
@justinkambic
Allow edits of filters for monitor alerts.
ccea1f0
@justinkambic
Support default parameter value for numTimes.
4caaeca
@justinkambic
Support default parameter values for timerange.
93739f5
@justinkambic
Modify kuery bar to work for alert edits, fix some filter issues.
c93037e
@justinkambic
Clean up tests and fix types.
87df991
@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 labels Jun 2, 2020
@justinkambic justinkambic self-assigned this Jun 2, 2020
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 2, 2020
@justinkambic justinkambic marked this pull request as ready for review June 3, 2020 13:55
@justinkambic justinkambic requested a review from a team as a code owner June 3, 2020 13:55
shahzad31
shahzad31 approved these changes Jun 5, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in testing alerts !!

@justinkambic
Copy link
Copy Markdown
Contributor Author

justinkambic commented Jun 5, 2020

@shahzad31 sorry to put you through another review, but I discovered another case where this wasn't behaving the way we want. I've committed significant code since your approval so we should verify that as well.

@justinkambic justinkambic requested a review from shahzad31 June 5, 2020 22:48
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 8, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31
shahzad31 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@justinkambic justinkambic merged commit 858523e into elastic:master Jun 8, 2020
@justinkambic justinkambic mentioned this pull request Jun 8, 2020
Merged
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jun 8, 2020
@justinkambic @elasticmachine @shahzad31
[Uptime] Edit uptime alerts (elastic#68005)
0bfe56b 
* Extract store creation to plugin start, add redux providers to alert registration.

* Update unit test.

* Move alert registration to `setup` function.

* Allow external editing of uptime client alert types.

* Move alert initialization back to `start`.

* Clean up interfaces for alert types.

* Add code that will work for settings link even outside uptime app.

* Create new atomic params type for status alerts.

* Update executor params typing to support both alert params types.

* Update snapshot for alert factory function.

* Fix broken types and refresh snapshots.

* Allow edits of filters for monitor alerts.

* Support default parameter value for numTimes.

* Support default parameter values for timerange.

* Modify kuery bar to work for alert edits, fix some filter issues.

* Clean up tests and fix types.

* Fix types and add a test.

* Add callout and validation handling for old alerts while editing.

* Add a test for updated validation function.

* Define window for overview filters fetch action.

* Revert store initialization.

* Make monitor counter function while editing alerts.

* Refresh snapshot.

* Move snapshot count in monitor status alert to callout.

* Add new state for selected filters.

* Add basic functional tests for uptime alert flyouts.

* Fix broken types.

* Update unit tests with mock provider.

* Remove unneeded params from hook.

* Add more unit tests.

* Reducing functional test flakiness.

* Alert flyout controls update url only within Uptime app.

* Extract context interaction to container component, update snapshots.

* Add missing parameter to test file.

* Remove flaky functional test.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
@justinkambic justinkambic mentioned this pull request Jun 8, 2020
Merged
justinkambic added a commit to justinkambic/kibana that referenced this pull request Jun 8, 2020
@justinkambic @elasticmachine @shahzad31
[Uptime] Edit uptime alerts (elastic#68005)
783697d 
* Extract store creation to plugin start, add redux providers to alert registration.

* Update unit test.

* Move alert registration to `setup` function.

* Allow external editing of uptime client alert types.

* Move alert initialization back to `start`.

* Clean up interfaces for alert types.

* Add code that will work for settings link even outside uptime app.

* Create new atomic params type for status alerts.

* Update executor params typing to support both alert params types.

* Update snapshot for alert factory function.

* Fix broken types and refresh snapshots.

* Allow edits of filters for monitor alerts.

* Support default parameter value for numTimes.

* Support default parameter values for timerange.

* Modify kuery bar to work for alert edits, fix some filter issues.

* Clean up tests and fix types.

* Fix types and add a test.

* Add callout and validation handling for old alerts while editing.

* Add a test for updated validation function.

* Define window for overview filters fetch action.

* Revert store initialization.

* Make monitor counter function while editing alerts.

* Refresh snapshot.

* Move snapshot count in monitor status alert to callout.

* Add new state for selected filters.

* Add basic functional tests for uptime alert flyouts.

* Fix broken types.

* Update unit tests with mock provider.

* Remove unneeded params from hook.

* Add more unit tests.

* Reducing functional test flakiness.

* Alert flyout controls update url only within Uptime app.

* Extract context interaction to container component, update snapshots.

* Add missing parameter to test file.

* Remove flaky functional test.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
# Conflicts:
#	x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx
justinkambic added a commit that referenced this pull request Jun 9, 2020
@justinkambic @elasticmachine
[Uptime] Edit uptime alerts (#68005) (#68560)
524dc2a 
* Extract store creation to plugin start, add redux providers to alert registration.

* Update unit test.

* Move alert registration to `setup` function.

* Allow external editing of uptime client alert types.

* Move alert initialization back to `start`.

* Clean up interfaces for alert types.

* Add code that will work for settings link even outside uptime app.

* Create new atomic params type for status alerts.

* Update executor params typing to support both alert params types.

* Update snapshot for alert factory function.

* Fix broken types and refresh snapshots.

* Allow edits of filters for monitor alerts.

* Support default parameter value for numTimes.

* Support default parameter values for timerange.

* Modify kuery bar to work for alert edits, fix some filter issues.

* Clean up tests and fix types.

* Fix types and add a test.

* Add callout and validation handling for old alerts while editing.

* Add a test for updated validation function.

* Define window for overview filters fetch action.

* Revert store initialization.

* Make monitor counter function while editing alerts.

* Refresh snapshot.

* Move snapshot count in monitor status alert to callout.

* Add new state for selected filters.

* Add basic functional tests for uptime alert flyouts.

* Fix broken types.

* Update unit tests with mock provider.

* Remove unneeded params from hook.

* Add more unit tests.

* Reducing functional test flakiness.

* Alert flyout controls update url only within Uptime app.

* Extract context interaction to container component, update snapshots.

* Add missing parameter to test file.

* Remove flaky functional test.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
# Conflicts:
#	x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@justinkambic
Copy link
Copy Markdown
Contributor Author

justinkambic commented Jun 9, 2020 •
edited
Loading

Backported to:

justinkambic added a commit that referenced this pull request Jun 9, 2020
@justinkambic @elasticmachine @shahzad31
[Uptime] Edit uptime alerts (#68005) (#68559)
f23ec71 
* Extract store creation to plugin start, add redux providers to alert registration.

* Update unit test.

* Move alert registration to `setup` function.

* Allow external editing of uptime client alert types.

* Move alert initialization back to `start`.

* Clean up interfaces for alert types.

* Add code that will work for settings link even outside uptime app.

* Create new atomic params type for status alerts.

* Update executor params typing to support both alert params types.

* Update snapshot for alert factory function.

* Fix broken types and refresh snapshots.

* Allow edits of filters for monitor alerts.

* Support default parameter value for numTimes.

* Support default parameter values for timerange.

* Modify kuery bar to work for alert edits, fix some filter issues.

* Clean up tests and fix types.

* Fix types and add a test.

* Add callout and validation handling for old alerts while editing.

* Add a test for updated validation function.

* Define window for overview filters fetch action.

* Revert store initialization.

* Make monitor counter function while editing alerts.

* Refresh snapshot.

* Move snapshot count in monitor status alert to callout.

* Add new state for selected filters.

* Add basic functional tests for uptime alert flyouts.

* Fix broken types.

* Update unit tests with mock provider.

* Remove unneeded params from hook.

* Add more unit tests.

* Reducing functional test flakiness.

* Alert flyout controls update url only within Uptime app.

* Extract context interaction to container component, update snapshots.

* Add missing parameter to test file.

* Remove flaky functional test.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
@justinkambic justinkambic deleted the uptime_edit-alerts-ahead branch June 9, 2020 20:43
@justinkambic justinkambic mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@justinkambic justinkambic

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uptime alerts aren't editable in Alerting Management UI

4 participants

@justinkambic @elasticmachine @kibanamachine @shahzad31