Skip to content

[7.8] [Uptime] Edit uptime alerts (#68005)#68560

Merged
justinkambic merged 3 commits intoelastic:7.8from
justinkambic:backport/7.8/pr-68005
Jun 9, 2020
Merged

[7.8] [Uptime] Edit uptime alerts (#68005)#68560
justinkambic merged 3 commits intoelastic:7.8from
justinkambic:backport/7.8/pr-68005

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.8:

* Extract store creation to plugin start, add redux providers to alert registration.

* Update unit test.

* Move alert registration to `setup` function.

* Allow external editing of uptime client alert types.

* Move alert initialization back to `start`.

* Clean up interfaces for alert types.

* Add code that will work for settings link even outside uptime app.

* Create new atomic params type for status alerts.

* Update executor params typing to support both alert params types.

* Update snapshot for alert factory function.

* Fix broken types and refresh snapshots.

* Allow edits of filters for monitor alerts.

* Support default parameter value for numTimes.

* Support default parameter values for timerange.

* Modify kuery bar to work for alert edits, fix some filter issues.

* Clean up tests and fix types.

* Fix types and add a test.

* Add callout and validation handling for old alerts while editing.

* Add a test for updated validation function.

* Define window for overview filters fetch action.

* Revert store initialization.

* Make monitor counter function while editing alerts.

* Refresh snapshot.

* Move snapshot count in monitor status alert to callout.

* Add new state for selected filters.

* Add basic functional tests for uptime alert flyouts.

* Fix broken types.

* Update unit tests with mock provider.

* Remove unneeded params from hook.

* Add more unit tests.

* Reducing functional test flakiness.

* Alert flyout controls update url only within Uptime app.

* Extract context interaction to container component, update snapshots.

* Add missing parameter to test file.

* Remove flaky functional test.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
# Conflicts:
#	x-pack/plugins/uptime/public/lib/alert_types/monitor_status.tsx
@justinkambic justinkambic added the backport This PR is a backport of another PR label Jun 8, 2020
@justinkambic
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@justinkambic justinkambic added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 labels Jun 9, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/uptime (Team:uptime)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic justinkambic self-assigned this Jun 9, 2020
@justinkambic justinkambic merged commit 524dc2a into elastic:7.8 Jun 9, 2020
@justinkambic justinkambic deleted the backport/7.8/pr-68005 branch June 9, 2020 20:42
@justinkambic justinkambic mentioned this pull request Jun 9, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants