[Telemetry] collect number of visualization saved in the past 7, 30 and 90 days#67865
Merged
stratoula merged 3 commits intoelastic:masterfrom Jun 8, 2020
Merged
Conversation
4c4da4e to
a617066
Compare
a1cce3b to
3d98ded
Compare
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
@stratoula I added the Kibana telemetry team as reviewers. |
Contributor
Author
|
Thank you @TinaHeiligers! |
afharo
approved these changes
Jun 4, 2020
Member
afharo
left a comment
There was a problem hiding this comment.
LGTM! I simply added some minor NITs in case you want to consider them! Great work! :)
x-pack/plugins/oss_telemetry/server/lib/tasks/visualizations/task_runner.ts
Outdated
Show resolved
Hide resolved
eeba6ec to
dfc0915
Compare
Contributor
|
@elasticmachine merge upstream |
flash1293
approved these changes
Jun 8, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested and works as expected, LGTM
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Jun 8, 2020
…nd 90 days (elastic#67865) * Update telemetry for visualizations to also count the vis from the past 30 and 90 days * Also add metrics for the saved visualizations for the past 7 days Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 8, 2020
* master: [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305) [security_solution] enable react-hooks/exhaustive-deps (elastic#68470) Closes elastic#66867 by adding missing, requried API params (elastic#68465) [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865) [Logs UI] View in context tweaks (elastic#67777) Kibana developer examples landing page (elastic#67049) Bump decompress package version (elastic#68386) fix elastic#66185 (elastic#66186) Bump pdfmake package version (elastic#68395) Unskip embeddables/adding_children suite (elastic#68111) Add embed mode options in the Share UI (elastic#58435) Adding key to avoid react warning (elastic#68491)
stratoula
added a commit
that referenced
this pull request
Jun 8, 2020
…nd 90 days (#67865) (#68520) * Update telemetry for visualizations to also count the vis from the past 30 and 90 days * Also add metrics for the saved visualizations for the past 7 days Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
|
tested on BC2- 7.9.0 - works great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #57847
We want to also add to each visualization stats the number of visualizations saved the last 30 and the last 90 days.
Right now we collect the stats with the following format:
"visualization_types": { "input_control_vis": { "total": 3, "spaces_min": 3, "spaces_max": 3, "spaces_avg": 3 }, "area": { "total": 4, "spaces_min": 4, "spaces_max": 4, "spaces_avg": 4 },and with this change is going to also collect the number of visualizations for the past 30 and 90 days:
"visualization_types": { "input_control_vis": { "total": 3, "spaces_min": 3, "spaces_max": 3, "spaces_avg": 3, "saved_30_days_total": 2, "saved_90_days_total": 3, }, "area": { "total": 4, "spaces_min": 4, "spaces_max": 4, "spaces_avg": 4, "saved_30_days_total": 2, "saved_90_days_total": 4, },How to test it:
Go to Dev Tools and remove all the tasks
POST /.kibana_task_manager/_delete_by_query { "query": { "match_all": {} } }Make a change to a server file in kibana (add an empty space for example)
Go to Management-->Advanced Setting->Telemetry-->See an example of what we collect
Check the visualization types field, it should contain the new values.
Checklist