Skip to content

[Logs UI] View in context tweaks#67777

Merged
afgomez merged 8 commits intoelastic:masterfrom
afgomez:64910-view-in-context-tweaks
Jun 8, 2020
Merged

[Logs UI] View in context tweaks#67777
afgomez merged 8 commits intoelastic:masterfrom
afgomez:64910-view-in-context-tweaks

Conversation

@afgomez
Copy link
Copy Markdown
Contributor

@afgomez afgomez commented May 29, 2020

Summary

Closes #64910

Makes some visual tweaks to the view in context UI.

  • Bigger hit area for the log line actions button

Screenshot 2020-05-29 at 17 17 55

  • Adjusted paddings and spacings in the modal itself.

Screenshot 2020-05-29 at 17 18 10

  • Use of EuiContextMenu for the actions menu

@afgomez afgomez added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels May 29, 2020
@afgomez afgomez added this to the Logs UI 7.9 milestone May 29, 2020
@afgomez afgomez requested a review from katrin-freihofner May 29, 2020 15:23
@afgomez afgomez requested a review from a team as a code owner May 29, 2020 15:23
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@katrin-freihofner
Copy link
Copy Markdown

🙌 thank you, this is great!

@Kerry350 Kerry350 self-requested a review June 5, 2020 10:07
Copy link
Copy Markdown
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@afgomez
Copy link
Copy Markdown
Contributor Author

afgomez commented Jun 8, 2020

@elasticmachine merge upstream

Copy link
Copy Markdown

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The shared observability component added the `ownFocus` property to the
popover menu. This added some accessibility text that we want to keep.
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit e66eaf7 into elastic:master Jun 8, 2020
@afgomez afgomez deleted the 64910-view-in-context-tweaks branch June 8, 2020 13:49
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 8, 2020
* master:
  [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305)
  [security_solution] enable react-hooks/exhaustive-deps (elastic#68470)
  Closes elastic#66867 by adding missing, requried API params (elastic#68465)
  [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865)
  [Logs UI] View in context tweaks (elastic#67777)
  Kibana developer examples landing page (elastic#67049)
  Bump decompress package version (elastic#68386)
  fix elastic#66185 (elastic#66186)
  Bump pdfmake package version (elastic#68395)
  Unskip embeddables/adding_children suite (elastic#68111)
  Add embed mode options in the Share UI (elastic#58435)
  Adding key to avoid react warning (elastic#68491)
afgomez pushed a commit that referenced this pull request Jun 9, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Logs UI] view in context visual fine-tuning

5 participants