[SIEM] Fixes column drag and drop in timeline-based views#67799
Merged
andrew-goldstein merged 3 commits intoelastic:masterfrom Jun 2, 2020
Merged
[SIEM] Fixes column drag and drop in timeline-based views#67799andrew-goldstein merged 3 commits intoelastic:masterfrom
andrew-goldstein merged 3 commits intoelastic:masterfrom
Conversation
## Summary Fixes a bug in timeline-based views, (e.g. the Host Events table), where a column would revert back to it's original position after being dragged and dropped to a new position. Only timeline-based views were effected, not the timeline itself. To reproduce: 1) On the SIEM Overview page, click the `View events` button 2) Drag and drop any column in the Events table to a new position **Expected Result** - The column is relocated to the position where it was dropped **Actual Result** - The column reverts to it's original position ## Testing - This PR adds a Cypress test for this scenario - The new test was successfully run (at least) 10 times via `node x-pack/plugins/siem/scripts/loop_cypress_tests.js` - This fix was desk tested in: - Chrome `83.0.4103.61` - Firefox `76.0.1` - Safari `13.1`
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
2 tasks
cnasikas
reviewed
Jun 1, 2020
x-pack/plugins/siem/public/common/components/drag_and_drop/drag_drop_context_wrapper.tsx
Show resolved
Hide resolved
cnasikas
reviewed
Jun 1, 2020
…eline.ts` as suggested, because this constant is applicable to timelines too (not just the Events view) - added a `.skip` to the `Events columns` test for now, because although it passed CI, I ran `pack/plugins/siem/scripts/loop_cypress_tests.js` over the weekend and observed a few failures. Other Cypress tests that are currently passing CI are also failing locally, suggesting this _may_ be a local issue, but I don't want to destablize CI, and this PR must be backported to `7.8` for the next BC.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cnasikas
approved these changes
Jun 2, 2020
Member
cnasikas
left a comment
There was a problem hiding this comment.
Thank you for this fix! LGTM! Tested locally, all work as expected.
This was referenced Jun 2, 2020
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Jun 2, 2020
) ## Summary Fixes a bug in timeline-based views, (e.g. the Host Events table), where a column would revert back to it's original position after being dragged and dropped to a new position. Only timeline-based views were effected, not the timeline itself. To reproduce: 1) On the SIEM Overview page, click the `View events` button 2) Drag and drop any column in the Events table to a new position **Expected Result** - The column is relocated to the position where it was dropped **Actual Result** - The column reverts to it's original position ## Testing - This PR adds a Cypress test for this scenario - The new test was successfully run (at least) 10 times via `node x-pack/plugins/siem/scripts/loop_cypress_tests.js` - This fix was desk tested in: - Chrome `83.0.4103.61` - Firefox `76.0.1` - Safari `13.1` # Conflicts: # x-pack/plugins/siem/public/common/components/drag_and_drop/drag_drop_context_wrapper.tsx # x-pack/plugins/siem/public/common/components/drag_and_drop/helpers.ts
andrew-goldstein
added a commit
that referenced
this pull request
Jun 2, 2020
…67965) ## Summary Fixes a bug in timeline-based views, (e.g. the Host Events table), where a column would revert back to it's original position after being dragged and dropped to a new position. Only timeline-based views were effected, not the timeline itself. To reproduce: 1) On the SIEM Overview page, click the `View events` button 2) Drag and drop any column in the Events table to a new position **Expected Result** - The column is relocated to the position where it was dropped **Actual Result** - The column reverts to it's original position ## Testing - This PR adds a Cypress test for this scenario - The new test was successfully run (at least) 10 times via `node x-pack/plugins/siem/scripts/loop_cypress_tests.js` - This fix was desk tested in: - Chrome `83.0.4103.61` - Firefox `76.0.1` - Safari `13.1`
andrew-goldstein
added a commit
that referenced
this pull request
Jun 2, 2020
…) (#67966) ## Summary Fixes a bug in timeline-based views, (e.g. the Host Events table), where a column would revert back to it's original position after being dragged and dropped to a new position. Only timeline-based views were effected, not the timeline itself. To reproduce: 1) On the SIEM Overview page, click the `View events` button 2) Drag and drop any column in the Events table to a new position **Expected Result** - The column is relocated to the position where it was dropped **Actual Result** - The column reverts to it's original position ## Testing - This PR adds a Cypress test for this scenario - The new test was successfully run (at least) 10 times via `node x-pack/plugins/siem/scripts/loop_cypress_tests.js` - This fix was desk tested in: - Chrome `83.0.4103.61` - Firefox `76.0.1` - Safari `13.1`
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in timeline-based views, (e.g. the Host Events table), where a column would revert back to it's original position after being dragged and dropped to a new position.
Only timeline-based views were effected, not the timeline itself.
To reproduce:
On the SIEM Overview page, click the
View eventsbuttonDrag and drop any column in the Events table to a new position
Expected Result
Actual Result
Testing
This PR adds a Cypress test for this scenario
node x-pack/plugins/siem/scripts/loop_cypress_tests.jsThis fix was desk tested in:
83.0.4103.6176.0.113.1