Skip to content

[7.8] [SIEM] Fixes column drag and drop in timeline-based views (#67799)#67966

Merged
andrew-goldstein merged 5 commits intoelastic:7.8from
andrew-goldstein:backport/7.8/pr-67799
Jun 2, 2020
Merged

[7.8] [SIEM] Fixes column drag and drop in timeline-based views (#67799)#67966
andrew-goldstein merged 5 commits intoelastic:7.8from
andrew-goldstein:backport/7.8/pr-67799

Conversation

@andrew-goldstein
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.8:

)

## Summary

Fixes a bug in timeline-based views, (e.g. the Host Events table), where a column would revert back to it's original position after being dragged and dropped to a new position.

Only timeline-based views were effected, not the timeline itself.

To reproduce:

1) On the SIEM Overview page, click the `View events` button

2) Drag and drop any column in the Events table to a new position

**Expected Result**

- The column is relocated to the position where it was dropped

**Actual Result**

- The column reverts to it's original position

## Testing

- This PR adds a Cypress test for this scenario
  - The new test was successfully run (at least) 10 times via `node x-pack/plugins/siem/scripts/loop_cypress_tests.js`

- This fix was desk tested in:
  - Chrome `83.0.4103.61`
  - Firefox `76.0.1`
  - Safari `13.1`

# Conflicts:
#	x-pack/plugins/siem/public/common/components/drag_and_drop/drag_drop_context_wrapper.tsx
#	x-pack/plugins/siem/public/common/components/drag_and_drop/helpers.ts
@andrew-goldstein andrew-goldstein added the backport This PR is a backport of another PR label Jun 2, 2020
@andrew-goldstein
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@andrew-goldstein
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@andrew-goldstein
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrew-goldstein andrew-goldstein merged commit f9da008 into elastic:7.8 Jun 2, 2020
@andrew-goldstein andrew-goldstein deleted the backport/7.8/pr-67799 branch June 2, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants