FYI: @myasonik & @snide

@cchaos thanks a log for your adaptations!

Things I can't

Any unchecked items in @snide's list and:

1. Similar to Dave's comments about the JSON blobs, I tried adding isCopyable to that EuiCodeBlock but it wasn't taking. It'd be a great improvement since select all doesn't scope to just the popover.

this seems like an bug with combining EuiPopover and the Codeblock? Since it seems to be rendered when the page is resized?

Maybe we should offer this functionality by an EuiDataGrid improvement?

2. The empty message only mentions time, but you can get into a situation where the table is empty because of the filters you've applied. It'd be great to update this message to be more generic or include a mention of filters, or better yet, KNOW it's because of filter.
   https://share.getcloudapp.com/DOuombBx

I do agree that we should mention it, and later on we could make it intelligent.
Dear @gchaps could you have a look at the wording to prevent my "denglish"? thx

3. If you have the details flyout open, and click Inspect in the menu bar, the inspect flyout is underneath the details.

I see! I this flyout needs to ownFocus, to prevent that, right?

4. Why can you filter for values in some cells but not others, even though in the details flyout you can filter for them? https://share.getcloudapp.com/12uK0XdP

Thx, already fixed it, part of the next push

5. The Toggle column button in the details flyout says "Toggle" but it doesn't ever remove it. https://share.getcloudapp.com/p9urX0Dm

Thx, yes. So this is tricky, didn't work in the legacy grid, but since every time one of this actions was executed, the legacy "flyout" closed. It's a bit complicated here, this doc viewer is module that can also contain angular, so it's rendered differently, and that seems to be the cause here. So we've got 3 choices here

1 ) open an issue for it, target in a separate PR
2) Also close the flyout when filter are added, rows are toggled
3) keep on debugging

6. Why can the date column never be "hidden"?

Yes, this is legacy behavior, it's to stay compatible with the old grid, but yes, we could think of making it possible later on, I think we should. It has a bit improved though, you can move the date column now, and it can't be duplicated, small wins here, big win later

7. Similar to Dave's question about the products field showing up as -. There are other fields that also show up as - like _score but then also show a popover with just -. https://share.getcloudapp.com/jkuYm9z7 Is it possible to know if that's the only content and remove the extra action of showing the content in a popover?

dear @chandlerprall, can I do this? don't make a cell expandable dependent on the content?

Some notes.

• We need to fix the spacing in the blob view. Right now there are no margins to the left of the blocks.
• Selected state of rows needs emphasis

you took care of that, right @cchaos

• We should add a toast or something to signify the actions in the flyouts happened. Since they are hidden behind.

Or we make them function like the legacy one, close the flyout, would also prevent a problem with toggling of columns

• Products field is rendering empty in the grid, but shows in the flyout.

Muchas gracias, fixed that

• In general, I think we need a schema to recognize JSON blobs, and apply that schema from EUI (for syntax highlighting in the popout)
• We can set the height for the chart header so that there's not a jump as you hide the chart. (this is because the select form has a larger height)

Dankeschön for taking care of it

• I would increase the default pagination to more than 25 results. It should be as high as we feel comfortable.

Will be done when virtualization, I'm comfortable with 5000000 then

about the geo field schema, so it should be handled like a JSON or differently? thx

@kertal did some more styling. We have some Amsterdam specific changes that we'll need to make (that shouldn't hold up this PR) after the break.

I'd still like to highlight the row selected if possible. Think you can pass me a className on the cells for the selected row? That way I can give it some emphasis once it's been expanded.

Other small thing I noticed in here (and can wait) is that we really need to replace the doc viewer table that shows in the expanded flyout to use an EuiTable. Right now it's using Bootstrap, and we're looking to remove that next minor.

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 71d943f
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Setup Build Environment and Dependencies
• Setup Build Environment and Dependencies

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [a98550b]

History

• 💚 Build #96116 succeeded 71d943f
• 💔 Build #96094 failed 46f60d7
• 💔 Build #96040 failed f482f11
• 💔 Build #96000 failed 5847ad9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream