[EuiDataGrid] Add sorting icon if the column is sorted#4343
[EuiDataGrid] Add sorting icon if the column is sorted#4343stratoula merged 6 commits intoelastic:masterfrom
Conversation
|
I have used the |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
snide
left a comment
There was a problem hiding this comment.
Added a minor PR to adjust some spacing. This is a nice PR with the appropriate tests.
I tested it extensively in browser in a couple scenarios. The truncation still works as I'd expect when the column is collapsed.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
|
@stratoula Don't forget a changelog before you merge this. |
|
@snide thank you, I def missed that 🙂 |
This comment has been minimized.
This comment has been minimized.
|
@stratoula disregard my last comment. Apparently it's more of a contentious change than I thought 😆 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
|
OK. @cchaos and I discussed. This is safe to merge as-is (upon @chandlerprall approval). We'll revisit the sorting arrows more generically in EUI (since tables use them) in a later PR. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/ |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; tested various configurations in the PR's published docs.
Thanks for the test coverage!
Summary
It adds a sorting indicator on the EuiDataGridColumn which renders only when the column is sorted and indicates the sorting direction.
Checklist