Skip to content

[Canvas] Fix fullscreen with new fixed header#67131

Merged
poffdeluxe merged 2 commits intoelastic:masterfrom
poffdeluxe:canvas-fix-fullscreen-header
May 21, 2020
Merged

[Canvas] Fix fullscreen with new fixed header#67131
poffdeluxe merged 2 commits intoelastic:masterfrom
poffdeluxe:canvas-fix-fullscreen-header

Conversation

@poffdeluxe
Copy link
Copy Markdown
Contributor

@poffdeluxe poffdeluxe commented May 20, 2020

Summary

When workpad is in fullscreen, remove the padding on the body DOM element and make sure app-wrapper can expand to fill the entire viewport

Fixes #66208

@poffdeluxe poffdeluxe added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. v7.8.0 v7.9.0 labels May 20, 2020
@poffdeluxe poffdeluxe requested a review from a team as a code owner May 20, 2020 17:40
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@poffdeluxe
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe poffdeluxe merged commit 0fd96e4 into elastic:master May 21, 2020
@poffdeluxe poffdeluxe deleted the canvas-fix-fullscreen-header branch May 21, 2020 13:43
poffdeluxe added a commit to poffdeluxe/kibana that referenced this pull request May 21, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
poffdeluxe added a commit that referenced this pull request May 21, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
poffdeluxe added a commit that referenced this pull request May 21, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 21, 2020
* master:
  Fix Canvas nav link in env with spaces (elastic#67127)
  Fix Canvas fullscreen with new fixed header (elastic#67131)
  [Index management] Add support in url for hidden toggle (elastic#66715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Canvas] White bar in fullscreen mode

4 participants