Skip to content

[Canvas] Fix last nav link with Spaces#67127

Merged
poffdeluxe merged 1 commit intoelastic:masterfrom
poffdeluxe:canvas-fix-np-space-navlink
May 21, 2020
Merged

[Canvas] Fix last nav link with Spaces#67127
poffdeluxe merged 1 commit intoelastic:masterfrom
poffdeluxe:canvas-fix-np-space-navlink

Conversation

@poffdeluxe
Copy link
Copy Markdown
Contributor

Summary

Fixes our last nav link path work using a similar method to the fix for this related issue #61938

Fixes #66573

@poffdeluxe poffdeluxe added bug Fixes for quality problems that affect the customer experience review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort v8.0.0 impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.8.0 v7.9.0 labels May 20, 2020
@poffdeluxe poffdeluxe requested a review from a team as a code owner May 20, 2020 16:48
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@poffdeluxe poffdeluxe added the release_note:skip Skip the PR/issue when compiling release notes label May 20, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe poffdeluxe merged commit 484e0a9 into elastic:master May 21, 2020
@poffdeluxe poffdeluxe deleted the canvas-fix-np-space-navlink branch May 21, 2020 13:54
poffdeluxe added a commit to poffdeluxe/kibana that referenced this pull request May 21, 2020
poffdeluxe added a commit to poffdeluxe/kibana that referenced this pull request May 21, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 21, 2020
* master:
  Fix Canvas nav link in env with spaces (elastic#67127)
  Fix Canvas fullscreen with new fixed header (elastic#67131)
  [Index management] Add support in url for hidden toggle (elastic#66715)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Canvas] Canvas tries to navigate to non-existing object when navigating between spaces

4 participants