Skip to content

[APM] Simplify element updates#66438

Merged
smith merged 1 commit intoelastic:masterfrom
smith:nls/node-clicks
May 13, 2020
Merged

[APM] Simplify element updates#66438
smith merged 1 commit intoelastic:masterfrom
smith:nls/node-clicks

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented May 13, 2020

There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data
when the date range changes.

Remove this and instead remove all elements and add new elements when the elements change.

Fixes #66184.

There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data
when the date range changes.

Remove this and instead remove all elements and add new elements when the elements change.

Fixes elastic#66184.
@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels May 13, 2020
@smith smith requested a review from a team May 13, 2020 17:10
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label May 13, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit c7587e4 into elastic:master May 13, 2020
smith added a commit to smith/kibana that referenced this pull request May 13, 2020
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data
when the date range changes.

Remove this and instead remove all elements and add new elements when the elements change.

Fixes elastic#66184.
smith added a commit to smith/kibana that referenced this pull request May 13, 2020
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data
when the date range changes.

Remove this and instead remove all elements and add new elements when the elements change.

Fixes elastic#66184.
smith added a commit that referenced this pull request May 14, 2020
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data
when the date range changes.

Remove this and instead remove all elements and add new elements when the elements change.

Fixes #66184.
smith added a commit that referenced this pull request May 14, 2020
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data
when the date range changes.

Remove this and instead remove all elements and add new elements when the elements change.

Fixes #66184.
smith added a commit to smith/kibana that referenced this pull request May 14, 2020
After simplyfying the layout mechanism in elastic#66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes elastic#66528.
smith added a commit that referenced this pull request May 14, 2020
After simplyfying the layout mechanism in #66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes #66528.
smith added a commit to smith/kibana that referenced this pull request May 14, 2020
After simplyfying the layout mechanism in elastic#66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes elastic#66528.
smith added a commit to smith/kibana that referenced this pull request May 14, 2020
After simplyfying the layout mechanism in elastic#66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes elastic#66528.
smith added a commit that referenced this pull request May 15, 2020
After simplyfying the layout mechanism in #66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes #66528.
smith added a commit that referenced this pull request May 15, 2020
After simplyfying the layout mechanism in #66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node.

Fixes #66528.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] Detailed popover takes a lot of time to show up after focusing on a node

4 participants