Merged
Conversation
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data when the date range changes. Remove this and instead remove all elements and add new elements when the elements change. Fixes elastic#66184.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
ogupte
approved these changes
May 13, 2020
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
May 13, 2020
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data when the date range changes. Remove this and instead remove all elements and add new elements when the elements change. Fixes elastic#66184.
smith
added a commit
to smith/kibana
that referenced
this pull request
May 13, 2020
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data when the date range changes. Remove this and instead remove all elements and add new elements when the elements change. Fixes elastic#66184.
smith
added a commit
that referenced
this pull request
May 14, 2020
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data when the date range changes. Remove this and instead remove all elements and add new elements when the elements change. Fixes #66184.
smith
added a commit
that referenced
this pull request
May 14, 2020
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data when the date range changes. Remove this and instead remove all elements and add new elements when the elements change. Fixes #66184.
smith
added a commit
to smith/kibana
that referenced
this pull request
May 14, 2020
After simplyfying the layout mechanism in elastic#66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node. Fixes elastic#66528.
smith
added a commit
that referenced
this pull request
May 14, 2020
After simplyfying the layout mechanism in #66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node. Fixes #66528.
smith
added a commit
to smith/kibana
that referenced
this pull request
May 14, 2020
After simplyfying the layout mechanism in elastic#66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node. Fixes elastic#66528.
smith
added a commit
to smith/kibana
that referenced
this pull request
May 14, 2020
After simplyfying the layout mechanism in elastic#66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node. Fixes elastic#66528.
smith
added a commit
that referenced
this pull request
May 15, 2020
After simplyfying the layout mechanism in #66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node. Fixes #66528.
smith
added a commit
that referenced
this pull request
May 15, 2020
After simplyfying the layout mechanism in #66438, we made it so the `data` event handler would run even if there are no elements. This causes the `layoutstop` handler to run as well, but if we have multiple renders with no elements, multiple `layoutstop` events would by triggered after the elements were loaded, causing the map to jump around, which is especially visible with a single node. Fixes #66528.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's some complexity in the Cytoscape component that was initially there to handle smooth transitions when adding elements to a graph, back when we were incrementally updating them, and for udpating the data
when the date range changes.
Remove this and instead remove all elements and add new elements when the elements change.
Fixes #66184.