[ML] API integration tests for job validation#66265
Merged
darnautov merged 15 commits intoelastic:masterfrom May 13, 2020
Merged
[ML] API integration tests for job validation#66265darnautov merged 15 commits intoelastic:masterfrom
darnautov merged 15 commits intoelastic:masterfrom
Conversation
…dation # Conflicts: # x-pack/plugins/ml/common/util/job_utils.ts
Contributor
|
Pinging @elastic/ml-ui (:ml) |
90 tasks
peteharverson
approved these changes
May 13, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
LGTM. The CSS edits should be removed from this PR, as they are now in the separate PR #66413.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
May 15, 2020
* [ML] TS refactoring * [ML] fix page overflow * [ML] tests * [ML] fix typing issues and unit tests * [ML] remove string conversion * [ML] indexOf checks * [ML] fix tooltip overflow * [ML] fix i18n * [ML] fix unit tests * [ML] use MlJobAggregation * [ML] use enums * Revert "[ML] fix tooltip overflow" This reverts commit 103c36b * Revert "[ML] fix page overflow" This reverts commit 3c86922
darnautov
added a commit
that referenced
this pull request
May 18, 2020
* [ML] TS refactoring * [ML] fix page overflow * [ML] tests * [ML] fix typing issues and unit tests * [ML] remove string conversion * [ML] indexOf checks * [ML] fix tooltip overflow * [ML] fix i18n * [ML] fix unit tests * [ML] use MlJobAggregation * [ML] use enums * Revert "[ML] fix tooltip overflow" This reverts commit 103c36b * Revert "[ML] fix page overflow" This reverts commit 3c86922
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #63700. Adds API integration tests for validating anomaly detection jobs.
It also contains:
some TS refactoring of the job validation related code
Unit or functional tests were updated or added to match the most common scenarios