Skip to content

[ML] Fix vertical overflow on Single Metric Viewer page#66413

Merged
darnautov merged 2 commits intoelastic:masterfrom
darnautov:ML-fix-scrollbar
May 13, 2020
Merged

[ML] Fix vertical overflow on Single Metric Viewer page#66413
darnautov merged 2 commits intoelastic:masterfrom
darnautov:ML-fix-scrollbar

Conversation

@darnautov
Copy link
Copy Markdown
Contributor

Summary

  • Fix double vertical page overflow that caused 2 scrollbars appeared on the Single Metric Viewer page.
  • Fix tiny chart tooltip overlap by a scrollbar.

Before:

image

After:
image

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit 69d4199 into elastic:master May 13, 2020
@darnautov darnautov deleted the ML-fix-scrollbar branch May 13, 2020 16:16
darnautov added a commit to darnautov/kibana that referenced this pull request May 13, 2020
* [ML] fix page overflow

* [ML] fix tooltip overflow
darnautov added a commit to darnautov/kibana that referenced this pull request May 13, 2020
* [ML] fix page overflow

* [ML] fix tooltip overflow
darnautov added a commit that referenced this pull request May 13, 2020
)

* [ML] fix page overflow

* [ML] fix tooltip overflow
darnautov added a commit that referenced this pull request May 14, 2020
)

* [ML] fix page overflow

* [ML] fix tooltip overflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants