Fix timepicker button behavior in "No Results" page for timeseries data by bevacqua · Pull Request #6543 · elastic/kibana

bevacqua · 2016-03-15T19:07:23Z

Fixes #4947. Assigning @tsullivan because he initially reported the issue. Wasn't exactly sure where tests would go, please advise :)

tsullivan · 2016-03-16T17:58:43Z

Sorry, I am not sure where tests should go. Perhaps @epixa or @spalger could advise.

tsullivan · 2016-03-16T18:03:50Z

LGTM

bevacqua · 2016-03-16T23:38:10Z

@spalger If you could take a look and let me know about any necessary tests that'd be awesome 🎉

spalger · 2016-03-18T01:06:05Z

Well, discover isn't well tested or easy to test right now, but if you move that button (or whole text) into a directive then you could test that (with kibana/public/discover/directives/no_results.js and kibana/public/discover/directives/__tests__/no_results.js).

Actually testing that clicking the button opens the timepicker is probably better done in a functional test though. So I would drop a couple data-test-subj attributes on the elements you want to test for, and then extend the functional discover tests to verify that clicking on the button does in fact toggle the timepicker.

rashidkpc · 2016-03-25T20:06:00Z

@bevacqua where are we on this guy?

…lastic#4947.

bevacqua · 2016-03-30T16:34:42Z

Working on tests

…directive and time picker.

spalger · 2016-03-30T17:12:20Z

src/plugins/kibana/public/discover/partials/no_results.html

@@ -0,0 +1,51 @@
+<div ng-show="resultState === 'none'" data-test-subj="discoverNoResults">


I'd prefer if this ng-show was moved to the site where this directive is injected.

…iscover's "No Results".

spalger · 2016-03-30T19:52:31Z

jenkins, test it

bevacqua · 2016-04-08T15:30:24Z

@spalger Build details are broken. Where can I look at the build output to learn what tests are failing here?

spalger · 2016-04-08T23:56:22Z

@bevacqua after a while builds are deleted. Just run the them again using a "jenkins, test it" comment.

rashidkpc · 2016-04-15T00:03:48Z

jenkins, test it

bevacqua · 2016-05-24T01:51:35Z

This is now fixed. @spalger up to re-review?

spalger · 2016-05-24T04:30:53Z

Count me in!

spalger · 2016-05-24T20:13:58Z

test/functional/apps/discover/_discover.js

        });

+        bdd.it('should not show "no results"', () => {
+          discoverPage.hasNoResults().then(visible => {


This needs to return a promise

bevacqua · 2016-05-26T21:01:02Z

@spalger Returns all the promises now

spalger · 2016-06-02T20:38:05Z

LGTM

bevacqua · 2016-06-02T22:22:55Z

Carry on 🎉

## Summary `eui@73.0.0` ⏩ `eui@74.0.1` --- ## [`74.0.1`](https://github.com/elastic/eui/tree/v74.0.1) **Bug fixes** - Fixed `EuiModalHeaderTitle` type errors when passed `EuiTitle` props ([#6547](elastic/eui#6547)) ## [`74.0.0`](https://github.com/elastic/eui/tree/v74.0.0) - Added the `component` prop to `EuiModalHeaderTitle`, which allows overriding the default `h1` tag ([#6530](elastic/eui#6530)) - Added the `titleProps` prop to `EuiConfirmModal`, which allows overriding the default `h1` tag ([#6530](elastic/eui#6530)) **Bug fixes** - Fixed slight row height jumping in `EuiBasicTable`s when actions with tooltips became disabled ([#6538](elastic/eui#6538)) **Breaking changes** - `EuiModalHeaderTitle` now **always** wraps its children in a `h1` tag (previously attempted to conditionally detect whether its children were raw strings or not). To change this tag type to, e.g. a more generic `div`, use the new `component` prop. ([#6530](elastic/eui#6530)) - `EuiLink` now applies `rel="noreferrer"` to all domains, including `elastic.co` ([#6535](elastic/eui#6535)) - `EuiBasicTable` no longer blocks mouse/keyboard interactions while `loading` ([#6543](elastic/eui#6543)) **CSS-in-JS conversions** - Converted `EuiBasicTable` to Emotion ([#6539](elastic/eui#6539)) - Added a new `RenderWithEuiTheme` render prop utility ([#6539](elastic/eui#6539)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

## Summary `eui@73.0.0` ⏩ `eui@74.0.1` --- ## [`74.0.1`](https://github.com/elastic/eui/tree/v74.0.1) **Bug fixes** - Fixed `EuiModalHeaderTitle` type errors when passed `EuiTitle` props ([elastic#6547](elastic/eui#6547)) ## [`74.0.0`](https://github.com/elastic/eui/tree/v74.0.0) - Added the `component` prop to `EuiModalHeaderTitle`, which allows overriding the default `h1` tag ([elastic#6530](elastic/eui#6530)) - Added the `titleProps` prop to `EuiConfirmModal`, which allows overriding the default `h1` tag ([elastic#6530](elastic/eui#6530)) **Bug fixes** - Fixed slight row height jumping in `EuiBasicTable`s when actions with tooltips became disabled ([elastic#6538](elastic/eui#6538)) **Breaking changes** - `EuiModalHeaderTitle` now **always** wraps its children in a `h1` tag (previously attempted to conditionally detect whether its children were raw strings or not). To change this tag type to, e.g. a more generic `div`, use the new `component` prop. ([elastic#6530](elastic/eui#6530)) - `EuiLink` now applies `rel="noreferrer"` to all domains, including `elastic.co` ([elastic#6535](elastic/eui#6535)) - `EuiBasicTable` no longer blocks mouse/keyboard interactions while `loading` ([elastic#6543](elastic/eui#6543)) **CSS-in-JS conversions** - Converted `EuiBasicTable` to Emotion ([elastic#6539](elastic/eui#6539)) - Added a new `RenderWithEuiTheme` render prop utility ([elastic#6539](elastic/eui#6539)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

bevacqua added review help wanted adoptme v5.0.0 labels Mar 15, 2016

bevacqua assigned tsullivan Mar 15, 2016

bevacqua force-pushed the bugfix/no-results-timepicker branch from 48120af to 57edb37 Compare March 15, 2016 19:07

tsullivan assigned bevacqua and unassigned tsullivan Mar 16, 2016

bevacqua assigned spalger and unassigned bevacqua Mar 16, 2016

spalger assigned bevacqua and unassigned spalger Mar 18, 2016

bevacqua removed the help wanted adoptme label Mar 18, 2016

bevacqua mentioned this pull request Mar 28, 2016

Drag aggregations to sort instead of having up/down arrows. #6566

Merged

[bugfix] Fix timepicker button behavior in "No Results" page. Fixes e…

348a939

…lastic#4947.

bevacqua force-pushed the bugfix/no-results-timepicker branch from 57edb37 to 348a939 Compare March 30, 2016 15:46

[test/functional] Functional tests covering new "No Results" partial …

4036c46

…directive and time picker.

bevacqua force-pushed the bugfix/no-results-timepicker branch from 6198feb to 4036c46 Compare March 30, 2016 17:09

spalger reviewed Mar 30, 2016
View reviewed changes

[test/functional] Add test case for expand/collapse timepicker from d…

bc0278f

…iscover's "No Results".

Merge branch 'master' into bugfix/no-results-timepicker

7ff2a35

[test] Fix test cases for No Results page.

50581a8

spalger assigned spalger and unassigned bevacqua May 24, 2016

spalger reviewed May 24, 2016
View reviewed changes

spalger assigned bevacqua and unassigned spalger May 24, 2016

[test] Return all the Promises.

b3b3128

bevacqua assigned spalger and bevacqua and unassigned bevacqua and spalger May 26, 2016

[test] Fix test fixtures.

496b8a9

bevacqua assigned spalger and unassigned bevacqua May 31, 2016

spalger assigned bevacqua and unassigned spalger Jun 2, 2016

bevacqua merged commit b6a0b89 into elastic:master Jun 2, 2016

bevacqua removed their assignment Jun 2, 2016

epixa added the v5.0.0-alpha4 label Jun 17, 2016

epixa added v5.0.0 and removed v5.0.0 labels Jun 28, 2016

		@@ -0,0 +1,51 @@
		<div ng-show="resultState === 'none'" data-test-subj="discoverNoResults">

Conversation

bevacqua commented Mar 15, 2016

Uh oh!

tsullivan commented Mar 16, 2016

Uh oh!

tsullivan commented Mar 16, 2016

Uh oh!

bevacqua commented Mar 16, 2016

Uh oh!

spalger commented Mar 18, 2016

Uh oh!

rashidkpc commented Mar 25, 2016

Uh oh!

bevacqua commented Mar 30, 2016

Uh oh!

spalger Mar 30, 2016

Choose a reason for hiding this comment

Uh oh!

bevacqua Mar 30, 2016

Choose a reason for hiding this comment

Uh oh!

spalger commented Mar 30, 2016

Uh oh!

bevacqua commented Apr 8, 2016

Uh oh!

spalger commented Apr 8, 2016

Uh oh!

rashidkpc commented Apr 15, 2016

Uh oh!

bevacqua commented May 24, 2016

Uh oh!

spalger commented May 24, 2016

Uh oh!

spalger May 24, 2016

Choose a reason for hiding this comment

Uh oh!

bevacqua commented May 26, 2016

Uh oh!

spalger commented Jun 2, 2016

Uh oh!

bevacqua commented Jun 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants