Changes to methods for getting more specific chart data#6530
Merged
LeeDr merged 6 commits intoelastic:masterfrom Mar 18, 2016
Merged
Changes to methods for getting more specific chart data#6530LeeDr merged 6 commits intoelastic:masterfrom
LeeDr merged 6 commits intoelastic:masterfrom
Conversation
added 4 commits
March 14, 2016 14:40
Author
|
jenkins, test it |
Contributor
|
jenkins, test it |
test/support/pages/visualize_page.js
Outdated
| .getVisibleText() | ||
| .then(function (yLabel) { | ||
| yAxisLabel = yLabel.replace(',', ''); | ||
| yAxisLabel = yLabel.replace(',', '').replace('%',''); |
Contributor
There was a problem hiding this comment.
nitpick, can we add a comment explaining why we are replacing these? if you want to do these in one replace we could do something .like replace(/(%|,)/g, '')
Contributor
|
made some small comments, LGTM otherwise. |
LeeDr
pushed a commit
that referenced
this pull request
Mar 18, 2016
Changes to methods for getting more specific chart data Added comments and minor change suggested by @jbudz. Only merging this to master for v5.0.
jbudz
pushed a commit
that referenced
this pull request
Jan 27, 2023
## Summary `eui@73.0.0` ⏩ `eui@74.0.1` --- ## [`74.0.1`](https://github.com/elastic/eui/tree/v74.0.1) **Bug fixes** - Fixed `EuiModalHeaderTitle` type errors when passed `EuiTitle` props ([#6547](elastic/eui#6547)) ## [`74.0.0`](https://github.com/elastic/eui/tree/v74.0.0) - Added the `component` prop to `EuiModalHeaderTitle`, which allows overriding the default `h1` tag ([#6530](elastic/eui#6530)) - Added the `titleProps` prop to `EuiConfirmModal`, which allows overriding the default `h1` tag ([#6530](elastic/eui#6530)) **Bug fixes** - Fixed slight row height jumping in `EuiBasicTable`s when actions with tooltips became disabled ([#6538](elastic/eui#6538)) **Breaking changes** - `EuiModalHeaderTitle` now **always** wraps its children in a `h1` tag (previously attempted to conditionally detect whether its children were raw strings or not). To change this tag type to, e.g. a more generic `div`, use the new `component` prop. ([#6530](elastic/eui#6530)) - `EuiLink` now applies `rel="noreferrer"` to all domains, including `elastic.co` ([#6535](elastic/eui#6535)) - `EuiBasicTable` no longer blocks mouse/keyboard interactions while `loading` ([#6543](elastic/eui#6543)) **CSS-in-JS conversions** - Converted `EuiBasicTable` to Emotion ([#6539](elastic/eui#6539)) - Added a new `RenderWithEuiTheme` render prop utility ([#6539](elastic/eui#6539)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
## Summary `eui@73.0.0` ⏩ `eui@74.0.1` --- ## [`74.0.1`](https://github.com/elastic/eui/tree/v74.0.1) **Bug fixes** - Fixed `EuiModalHeaderTitle` type errors when passed `EuiTitle` props ([elastic#6547](elastic/eui#6547)) ## [`74.0.0`](https://github.com/elastic/eui/tree/v74.0.0) - Added the `component` prop to `EuiModalHeaderTitle`, which allows overriding the default `h1` tag ([elastic#6530](elastic/eui#6530)) - Added the `titleProps` prop to `EuiConfirmModal`, which allows overriding the default `h1` tag ([elastic#6530](elastic/eui#6530)) **Bug fixes** - Fixed slight row height jumping in `EuiBasicTable`s when actions with tooltips became disabled ([elastic#6538](elastic/eui#6538)) **Breaking changes** - `EuiModalHeaderTitle` now **always** wraps its children in a `h1` tag (previously attempted to conditionally detect whether its children were raw strings or not). To change this tag type to, e.g. a more generic `div`, use the new `component` prop. ([elastic#6530](elastic/eui#6530)) - `EuiLink` now applies `rel="noreferrer"` to all domains, including `elastic.co` ([elastic#6535](elastic/eui#6535)) - `EuiBasicTable` no longer blocks mouse/keyboard interactions while `loading` ([elastic#6543](elastic/eui#6543)) **CSS-in-JS conversions** - Converted `EuiBasicTable` to Emotion ([elastic#6539](elastic/eui#6539)) - Added a new `RenderWithEuiTheme` render prop utility ([elastic#6539](elastic/eui#6539)) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to support Integration Testing.
visualizePage.getAreaChartData('Count') now requires the name of the aggregation to get the data for (it used to only get 'Count'). This allows getting the data from area charts with multiple aggregations shown.
And I'm afraid this is not completely consistent that I changed visualizePage.getLineChartData('fill="#57c17b"') to take a 'cssPart' which could be the fill color or could be a data-label attribute. I had cases where I had to use each.
I could change getAreaChartData to also take a cssPart (attribute) so they were consistent?