Merged
Conversation
Bumps [jquery](https://github.com/jquery/jquery) from 3.4.1 to 3.5.0. - [Release notes](https://github.com/jquery/jquery/releases) - [Commits](jquery/jquery@3.4.1...3.5.0) Signed-off-by: dependabot[bot] <support@github.com>
Contributor
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
|
retest |
The jQuery update includes a breaking change in the `htmlPrefilter` sanitization method. It handles self-closing tags differently when they are applied to HTML elements that may have content. Angular manipulates the DOM to add content to elements, and some of Kibana's usage of Angular included non-standard self-closing tags. This commit changes those elements to use separate open/close tags.
Contributor
|
retest |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
retest |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
retest |
thomasneirynck
approved these changes
May 5, 2020
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
maps/* tested and works
tylersmalley
approved these changes
May 5, 2020
flash1293
approved these changes
May 5, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested locally and LGTM - didn't notice anything broken in Discover/Visualize/Dashboard/Graph
igoristic
approved these changes
May 5, 2020
Contributor
igoristic
left a comment
There was a problem hiding this comment.
Tested, and everything looks good from Stack Monitoring pov ✅
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced May 5, 2020
jportner
pushed a commit
to jportner/kibana
that referenced
this pull request
May 5, 2020
# Conflicts: # packages/kbn-ui-shared-deps/package.json # src/plugins/visualize/public/application/editor/editor.html # x-pack/plugins/monitoring/public/directives/main/index.html
jportner
pushed a commit
to jportner/kibana
that referenced
this pull request
May 5, 2020
# Conflicts: # packages/kbn-ui-shared-deps/package.json # src/plugins/dashboard/public/application/listing/dashboard_listing_ng_wrapper.html # src/plugins/visualize/public/application/editor/editor.html # x-pack/package.json # x-pack/plugins/graph/public/angular/templates/index.html # x-pack/plugins/graph/public/angular/templates/listing_ng_wrapper.html # x-pack/plugins/maps/public/angular/listing_ng_wrapper.html # x-pack/plugins/monitoring/public/directives/main/index.html # yarn.lock
jportner
added a commit
that referenced
this pull request
May 5, 2020
jportner
added a commit
that referenced
this pull request
May 5, 2020
jportner
added a commit
that referenced
this pull request
May 6, 2020
jportner
added a commit
to jportner/kibana
that referenced
this pull request
May 19, 2020
jportner
added a commit
that referenced
this pull request
May 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps jquery from 3.4.1 to 3.5.0.
Commits
7a0a8503.5.08570a08Release: Update AUTHORS.txtda3dd85Ajax: Do not execute scripts for unsuccessful HTTP responses065143cAjax: Overwrite s.contentType with content-type header value, if any1a4f10dTests: Blacklist one focusin test in IE9e15d6bEvent: Use only one focusin/out handler per matching window & document966a709Manipulation: Skip the select wrapper for <option> outside of IE 91d61fd9Manipulation: Make jQuery.htmlPrefilter an identity function04bf577Selector: Update Sizzle from 2.3.4 to 2.3.57506c9cBuild: Resolve Travis config warningsMaintainer changes
This version was pushed to npm by mgol, a new releaser for jquery since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.
Edit by @jportner:
Needed to apply some code changes in f562e84 to prevent this from breaking some webpages. jQuery changed the
htmlPrefiltersanitization method to be more strict, so self-closing tags with no content are now stripped out of the DOM. This commit simply changes those elements to use explicit close tags.