[6.8] Bump jquery from 3.4.1 to 3.5.0 (#64884) again#67036
Merged
jportner merged 4 commits intoelastic:6.8from May 21, 2020
Merged
[6.8] Bump jquery from 3.4.1 to 3.5.0 (#64884) again#67036jportner merged 4 commits intoelastic:6.8from
jportner merged 4 commits intoelastic:6.8from
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second attempt at the original backport in #65336.
jQuery 3.5.0 introduced a breaking change to its
htmlPrefiltersanitization method so it is more strict. Self-closing tags with no content are now stripped out of the DOM. Self-closing tags should only be used by elements defined in the HTML Standard, such as<br />,<hr />, etc. This backport includes the update to jQuery 3.5.0, and also refactors Angular templates that previously (mis-)used self-closing tags.The original backport broke ML by preventing page loads. This was triaged in #66170, and the root cause was determined to be additional Angular templates that were defined programmatically via string literals. I missed those templates during that backport process. We wound up reverting that backport with the aim to revisit this upgrade, which I am doing in this PR.
This time, I manually reviewed all Angular template entry-points (usage of the
ui/routesmodule) to determine if we missed any other programmatically-defined Angular templates. I found one last instance in the Upgrade Assistant and updated it too (in 808cd21).