[Uptime] Flatten dynamic settings object, update saved object mapping#64856
Merged
justinkambic merged 6 commits intoelastic:masterfrom May 5, 2020
Merged
[Uptime] Flatten dynamic settings object, update saved object mapping#64856justinkambic merged 6 commits intoelastic:masterfrom
justinkambic merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
requested changes
May 5, 2020
shahzad31
approved these changes
May 5, 2020
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
May 5, 2020
…elastic#64856) * Flatten dynamic settings object, update saved object mapping. * Update broken types. * Delete commented code. * Rename a test. # Conflicts: # x-pack/plugins/uptime/common/constants/settings_defaults.ts # x-pack/plugins/uptime/server/lib/alerts/__tests__/status_check.test.ts
justinkambic
added a commit
that referenced
this pull request
May 6, 2020
…apping (#64856) (#65356) * [Uptime] Flatten dynamic settings object, update saved object mapping (#64856) * Flatten dynamic settings object, update saved object mapping. * Update broken types. * Delete commented code. * Rename a test. # Conflicts: # x-pack/plugins/uptime/common/constants/settings_defaults.ts # x-pack/plugins/uptime/server/lib/alerts/__tests__/status_check.test.ts * Update broken test snapshots.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves elastic/uptime#175.
Code is WIPDo not merge before any of:
That being said, it is important to merge this for 7.8 because we'll otherwise have a one-off version where we support a weird settings shape.
Checklist
Delete any items that are not applicable to this PR.
For maintainers