[Uptime] Certificates page#64059
Merged
shahzad31 merged 58 commits intoelastic:masterfrom May 1, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
x-pack/legacy/plugins/uptime/public/components/certificates/cert_status.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/certificates/certificates_list.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/certificates/certificates_list.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/certificates/translations.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/certificates/translations.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/cert_status_column.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/cert_status_column.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/overview/monitor_list/monitor_list.tsx
Show resolved
Hide resolved
andrewvc
requested changes
Apr 30, 2020
Contributor
andrewvc
left a comment
There was a problem hiding this comment.
Needs some minor changes. Overall, very clean code!
x-pack/plugins/uptime/public/components/certificates/__tests__/cert_status.test.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/certificates/certificates_list.tsx
Outdated
Show resolved
Hide resolved
...time/public/components/monitor/monitor_status_details/monitor_status_bar/ssl_certificate.tsx
Outdated
Show resolved
Hide resolved
...ns/uptime/public/components/monitor/monitor_status_details/monitor_status_bar/status_bar.tsx
Outdated
Show resolved
Hide resolved
x-pack/test/functional/es_archives/uptime/full_heartbeat/mappings.json
Outdated
Show resolved
Hide resolved
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
This is a great feature addition, and the code is super clean and well thought-out.
I had a few comments but great that we're this close on an initial review for such a large change!
x-pack/plugins/uptime/public/components/certificates/cert_status.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/certificates/cert_status.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/certificates/certificates_list.tsx
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/certificates/certificates_list.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/uptime/public/components/certificates/fingerprint_col.tsx
Show resolved
Hide resolved
7 tasks
andrewvc
approved these changes
May 1, 2020
Contributor
andrewvc
left a comment
There was a problem hiding this comment.
LGTM Pending @justinkambic 's changes
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
v1v
added a commit
to v1v/kibana
that referenced
this pull request
May 4, 2020
* upstream/master: (315 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 4, 2020
…or-part-mvp-2 * 'master' of github.com:elastic/kibana: (51 commits) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) Ingest Node Pipelines UI (elastic#62321) ... # Conflicts: # x-pack/plugins/ingest_pipelines/common/types.ts # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx # x-pack/plugins/ingest_pipelines/public/shared_imports.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 4, 2020
* master: (44 commits) onEvent prop for expression component (elastic#64995) [APM] Fix failing `ApmIndices` test (elastic#64965) [APM] Fix paths for ts optimization script (elastic#65012) Use HDR for percentiles (elastic#64758) [EPM] fix updates available filter (elastic#64957) [Uptime] Certificates page (elastic#64059) load lens app lazily (elastic#64769) [legacy/server/config] remove unnecessary deps for simple helper (elastic#64954) Fixed alert Edit flyout shows the error message when one of this actions has a preconfigured action type (elastic#64742) [data.search.aggs] Remove legacy aggs APIs. (elastic#64719) Fixed `AddAlert` flyout does not immediately update state to reflect new props (elastic#64927) [Discover] Show doc viewer action buttons on focus (elastic#64912) [EPM] restrict package install endpoint from installing/updating to old packages (elastic#64932) [Metrics UI] Add inventory metric threshold alerts (elastic#64292) [Canvas] Adds edit menu (elastic#64738) [Canvas] Adds refresh and autoplay options to view menu (elastic#64375) [Lens] Trigger a filter action on click in datatable visualization (elastic#63840) [SIEM][CASE] Refactor Connectors - Jira Connector (elastic#63450) [APM] Client new platform migration (elastic#64046) [Monitoring] NP Migration complete client cutover (elastic#62908) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
May 4, 2020
shahzad31
added a commit
that referenced
this pull request
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: elastic/uptime#161
Added Cert Page