[alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime#63489
Merged
gmmorris merged 6 commits intoelastic:masterfrom Apr 16, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
rylnd
approved these changes
Apr 14, 2020
Contributor
rylnd
left a comment
There was a problem hiding this comment.
SIEM changes look good to me. Thanks for doing this!
gmmorris
commented
Apr 15, 2020
Comment on lines
+51
to
+56
| services.savedObjectsClient.get.mockResolvedValue({ | ||
| id: '', | ||
| type: '', | ||
| references: [], | ||
| attributes: defaultDynamicSettings, | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
Hi @elastic/uptime
Looks like the typing has unearthed a possible mistake in the Unit Test where the mock returned the dynamic settings as the saved object, instead of the attributes of the saved object. I think this fix is in line with the implementation.
Note that this change has updated the snapshots below, so please verify this is still correct. :)
chrisronline
approved these changes
Apr 15, 2020
Contributor
chrisronline
left a comment
There was a problem hiding this comment.
LGTM from Stack Monitoring, assuming green CI. Thanks for doing this!
streamich
approved these changes
Apr 15, 2020
Contributor
streamich
left a comment
There was a problem hiding this comment.
I'm just giving this ✅ for AppArch team (no files modified for AppArch).
Contributor
|
Additional SIEM changes look great, the cleanup is much appreciated 👍 |
justinkambic
approved these changes
Apr 15, 2020
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
LGTM from the Uptime side.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 16, 2020
… and uptime (elastic#63489) Work on elastic#61313 has revealed that we don't have amock for AlertServices, which creates coupling between us and any solution depending on us, which makes it harder to make changes in our own code. This PR adds mocks and uses them in SIEM, Monitoring and Uptime, so that we can make future changes without having to change outside solutions.
gmmorris
added a commit
that referenced
this pull request
Apr 16, 2020
…toring and uptime (#63489) (#63662) Work on #61313 has revealed that we don't have amock for AlertServices, which creates coupling between us and any solution depending on us, which makes it harder to make changes in our own code. This PR adds mocks and uses them in SIEM, Monitoring and Uptime, so that we can make future changes without having to change outside solutions.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 17, 2020
* master: (56 commits) [i18n] Update CODEOWNERS (elastic#63354) add platform team definition of done (elastic#59993) [SIEM] move away from Joi for importing/exporting timeline (elastic#62125) Fix discover preserve url (elastic#63580) [alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (elastic#63489) Closes elastic#63109 for Service Map by resetting edges styles for the selected node (elastic#63655) MIgrated index_header to react (elastic#63490) Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table) (elastic#63364) [SIEM] [Cases] Insert timeline and reporters/tags in table bug fixes (elastic#63642) [Reporting] Make usable default element positions (elastic#63191) [Reporting] Switch Serverside Config Wrapper to NP (elastic#62500) [Reporting] Add "warning" status as an alternate type of completed job (elastic#63498) Split action types into own page (elastic#63516) [Lens] Only show copy on save for previously saved docs (elastic#63535) Update README.md (elastic#63622) Bugfix clear saved query crashes kibana on Discover in some cases (elastic#63554) Add uptime CODEOWNER entries. (elastic#63616) [ML] Extract apiDoc params from the schema definitions (elastic#62933) Fix alerting documentation encryption key requirement (elastic#63512) Fix CODEOWNERS and sass lint paths (elastic#63552) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Work on #61313 has revealed that we don't have amock for AlertServices, which creates coupling between us and any solution depending on us, which makes it harder to make changes in our own code.
This PR adds mocks and uses them in SIEM, Monitoring and Uptime, so that we can make future changes without having to change outside solutions.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers