Skip to content

Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table)#63364

Merged
VladLasitsa merged 5 commits intoelastic:masterfrom
VladLasitsa:#51322(indexed_fields_table)
Apr 16, 2020
Merged

Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table)#63364
VladLasitsa merged 5 commits intoelastic:masterfrom
VladLasitsa:#51322(indexed_fields_table)

Conversation

@VladLasitsa
Copy link
Copy Markdown
Contributor

@VladLasitsa VladLasitsa commented Apr 13, 2020

Part of #51322

Summary

Migrated indexed_fields_table and its tests to typescript.

For maintainers

@VladLasitsa VladLasitsa requested a review from alexwizp April 13, 2020 15:46
@alexwizp alexwizp requested a review from mattkime April 14, 2020 15:50
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@VladLasitsa VladLasitsa self-assigned this Apr 15, 2020
fieldWildcardMatcher={() => {
return () => false;
}}
indexedFieldTypeFilter=""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's not a required now =)

Copy link
Copy Markdown
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@alexwizp alexwizp marked this pull request as ready for review April 15, 2020 10:25
@alexwizp alexwizp requested a review from a team as a code owner April 15, 2020 10:25
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa VladLasitsa merged commit ce9c6e2 into elastic:master Apr 16, 2020
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Apr 16, 2020
…exed_fields_table) (elastic#63364)

* MIgrated indexed_fields_table to typescript.

* Updated docs

* Fixed comments

* Fixed types
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 17, 2020
* master: (56 commits)
  [i18n] Update CODEOWNERS (elastic#63354)
  add platform team definition of done (elastic#59993)
  [SIEM] move away from Joi for importing/exporting timeline (elastic#62125)
  Fix discover preserve url (elastic#63580)
  [alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (elastic#63489)
  Closes elastic#63109 for Service Map by resetting edges styles for the selected node (elastic#63655)
  MIgrated index_header to react (elastic#63490)
  Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table) (elastic#63364)
  [SIEM] [Cases] Insert timeline and reporters/tags in table bug fixes (elastic#63642)
  [Reporting] Make usable default element positions (elastic#63191)
  [Reporting] Switch Serverside Config Wrapper to NP (elastic#62500)
  [Reporting] Add "warning" status as an alternate type of completed job (elastic#63498)
  Split action types into own page (elastic#63516)
  [Lens] Only show copy on save for previously saved docs (elastic#63535)
  Update README.md (elastic#63622)
  Bugfix clear saved query crashes kibana on Discover in some cases (elastic#63554)
  Add uptime CODEOWNER entries. (elastic#63616)
  [ML] Extract apiDoc params from the schema definitions (elastic#62933)
  Fix alerting documentation encryption key requirement (elastic#63512)
  Fix CODEOWNERS and sass lint paths (elastic#63552)
  ...
VladLasitsa added a commit that referenced this pull request Apr 17, 2020
…y (indexed_fields_table) (#63364) (#63659)

* Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table) (#63364)

* MIgrated indexed_fields_table to typescript.

* Updated docs

* Fixed comments

* Fixed types

* Fixed types.

* Fixed types

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants