[SEARCH] Cleanup fetch soon by lizozom · Pull Request #63320 · elastic/kibana

lizozom · 2020-04-12T13:13:33Z

Summary

Part of #61738
Resolves #61739

Use the new search service directly from search source for the search and fallback to fetchSoon only if batchSearches is enable.

All msearch functionality is in a legacy folder, for easy removal in v8.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…p-fetch-soon

elasticmachine · 2020-04-12T13:13:35Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

lizozom · 2020-04-14T09:02:05Z

@elasticmachine merge upstream

…p-fetch-soon

lukasolson

Added a couple of minor notes below but overall LGTM. Happy to see this stuff in its temporary resting place before we can let it R.I.P.

src/plugins/data/public/search/search_source/search_source.ts

…p-fetch-soon

… into search/cleanup-fetch-soon

cjcenizal

I see the rollup_search_strategy file has been removed from the rollup plugin. This code change looks fine to me, but I haven't tested the rollup search behavior because I am assuming the App team or someone who works on Kibana apps that depend on this behavior will test or has tested. I'm approving to remove the codeowner block, but be warned I haven't done any local testing or reviewed any other code. :)

…p-fetch-soon

kibanamachine · 2020-04-19T10:44:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f49bdde

History

💔 Build #41203 failed d8d68bb
💚 Build #40597 succeeded 4ba4edd
💚 Build #40352 succeeded 30a87a6
💔 Build #40315 failed e3f9d10
💔 Build #40313 failed 3ffe1d6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* move old code to legacy folder * Use search service directly from search source * Move get search params to fetch folder * Delete search strategy folder * Doc update * Minor cleanups * Moved es client to legacy folder * Clean up some unused code (isViable, old search function) * Updated tests * strings update * Fix jest test * re-arrange runSearch function * re-arrange runSearch function * fix jest tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…bana into ingest-node-pipelines/privileges * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (126 commits) [SEARCH] Cleanup fetch soon (elastic#63320) skip flaky suite (elastic#58692) [Uptime] Refresh index and also show more info to user regardi… (elastic#62606) [Drilldowns] Fix back button by removing panels from url in dashboard in view mode (elastic#62415) [platform] serve plugins from /bundles/plugin:${id} [Alerting] Documentation for how to pre-configure connectors. (elastic#63807) skip flaky suite (elastic#63621) Revert "skip flaky suite (elastic#63747)" skip flaky suite (elastic#63747) [SIEM][Detections Engine] - Update rule.lists to be rule.exceptions_list (elastic#63717) [SIEM] Flaky test fix: Bump find_statuses timeout (elastic#63900) [Uptime] Add cert API request and runtime type checking (elastic#63062) [Lens] Allow table to scroll horizontally (elastic#63805) [Metrics UI] Allow users to create alerts from the central Alerts UI (elastic#63803) Migrate legacy maps licensing (x-pack/tilemap) to NP (elastic#63539) [Alerting] "Create alert" and alert list design improvements (elastic#63515) [Lens] Fix existence for dotted paths in _source (elastic#63752) Example plugins in X-Pack (elastic#63823) [ML] Migrate Mocha unit tests to Jest: migrate job utils and query utils tests (elastic#63775) Endpoint: middleware receive immutable versions of state and actions (elastic#63802) ...

* [SEARCH] Cleanup fetch soon (#63320) * move old code to legacy folder * Use search service directly from search source * Move get search params to fetch folder * Delete search strategy folder * Doc update * Minor cleanups * Moved es client to legacy folder * Clean up some unused code (isViable, old search function) * Updated tests * strings update * Fix jest test * re-arrange runSearch function * re-arrange runSearch function * fix jest tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * remove file (bad merge) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (127 commits) [Ingest pipelines] Polish details panel and empty list (elastic#63926) [SEARCH] Cleanup fetch soon (elastic#63320) skip flaky suite (elastic#58692) [Uptime] Refresh index and also show more info to user regardi… (elastic#62606) [Drilldowns] Fix back button by removing panels from url in dashboard in view mode (elastic#62415) [platform] serve plugins from /bundles/plugin:${id} [Alerting] Documentation for how to pre-configure connectors. (elastic#63807) skip flaky suite (elastic#63621) Revert "skip flaky suite (elastic#63747)" skip flaky suite (elastic#63747) [SIEM][Detections Engine] - Update rule.lists to be rule.exceptions_list (elastic#63717) [SIEM] Flaky test fix: Bump find_statuses timeout (elastic#63900) [Uptime] Add cert API request and runtime type checking (elastic#63062) [Lens] Allow table to scroll horizontally (elastic#63805) [Metrics UI] Allow users to create alerts from the central Alerts UI (elastic#63803) Migrate legacy maps licensing (x-pack/tilemap) to NP (elastic#63539) [Alerting] "Create alert" and alert list design improvements (elastic#63515) [Lens] Fix existence for dotted paths in _source (elastic#63752) Example plugins in X-Pack (elastic#63823) [ML] Migrate Mocha unit tests to Jest: migrate job utils and query utils tests (elastic#63775) ...

This reverts commit 6ee7111.

spalger · 2020-04-20T17:06:37Z

@lizozom I needed to revert the 7.x backport of this because it broke the type check in 7.x once it was merged. I'm resubmitting the backport now and hopefully will be able to get it remerged today.

* move old code to legacy folder * Use search service directly from search source * Move get search params to fetch folder * Delete search strategy folder * Doc update * Minor cleanups * Moved es client to legacy folder * Clean up some unused code (isViable, old search function) * Updated tests * strings update * Fix jest test * re-arrange runSearch function * re-arrange runSearch function * fix jest tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* move old code to legacy folder * Use search service directly from search source * Move get search params to fetch folder * Delete search strategy folder * Doc update * Minor cleanups * Moved es client to legacy folder * Clean up some unused code (isViable, old search function) * Updated tests * strings update * Fix jest test * re-arrange runSearch function * re-arrange runSearch function * fix jest tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Liza Katz <liza.katz@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

spalger · 2020-04-20T22:16:40Z

Re-backported #63983

* move old code to legacy folder * Use search service directly from search source * Move get search params to fetch folder * Delete search strategy folder * Doc update * Minor cleanups * Moved es client to legacy folder * Clean up some unused code (isViable, old search function) * Updated tests * strings update * Fix jest test * re-arrange runSearch function * re-arrange runSearch function * fix jest tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/data/public/search/search_service.ts # src/plugins/data/public/search/search_source/search_source.test.ts # src/plugins/data/public/search/search_source/search_source.ts # x-pack/legacy/plugins/rollup/public/search/rollup_search_strategy.ts # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

Liza K added 10 commits April 6, 2020 21:15

move old code to legacy folder

af0513f

Merge branch 'master' of github.com:elastic/kibana into search/cleanu…

8992ac0

…p-fetch-soon

Use search service directly from search source

9125611

Move get search params to fetch folder

a3773b9

Delete search strategy folder

a7ccef8

Doc update

3104896

Minor cleanups

8ee5e01

Moved es client to legacy folder

3e43cf4

Clean up some unused code (isViable, old search function)

2b8610d

Updated tests

3ffe1d6

lizozom added v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 12, 2020

lizozom self-assigned this Apr 12, 2020

lizozom requested a review from lukasolson April 12, 2020 13:14

Liza K added 2 commits April 12, 2020 17:51

strings update

e3f9d10

Fix jest test

2a1d42a

lizozom marked this pull request as ready for review April 13, 2020 08:08

lizozom requested review from a team as code owners April 13, 2020 08:08

re-arrange runSearch function

30a87a6

elasticmachine and others added 2 commits April 14, 2020 05:02

Merge branch 'master' into search/cleanup-fetch-soon

4ba4edd

Merge branch 'master' of github.com:elastic/kibana into search/cleanu…

57d5a8e

…p-fetch-soon

lukasolson approved these changes Apr 15, 2020

View reviewed changes

src/plugins/data/public/search/search_source/search_source.ts Outdated Show resolved Hide resolved

src/plugins/data/public/search/search_source/search_source.ts Outdated Show resolved Hide resolved

Liza K added 3 commits April 16, 2020 12:24

Merge branch 'master' of github.com:elastic/kibana into search/cleanu…

4ba4540

…p-fetch-soon

re-arrange runSearch function

92a7f99

Merge branch 'search/cleanup-fetch-soon' of github.com:lizozom/kibana…

d8d68bb

… into search/cleanup-fetch-soon

fix jest tests

584f7c6

cjcenizal approved these changes Apr 16, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into search/cleanu…

f49bdde

…p-fetch-soon

lizozom merged commit 796421f into elastic:master Apr 19, 2020

lizozom mentioned this pull request Apr 19, 2020

[7.x] [SEARCH] Cleanup fetch soon (#63320) #63929

Merged

spalger added a commit that referenced this pull request Apr 20, 2020

Revert "[7.x] [SEARCH] Cleanup fetch soon (#63320) (#63929)"

5498a23

This reverts commit 6ee7111.

spalger mentioned this pull request Apr 20, 2020

[7.x] [SEARCH] Cleanup fetch soon (#63320) #63983

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SEARCH] Cleanup fetch soon#63320

[SEARCH] Cleanup fetch soon#63320
lizozom merged 20 commits intoelastic:masterfrom
lizozom:search/cleanup-fetch-soon

lizozom commented Apr 12, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Apr 12, 2020

Uh oh!

lizozom commented Apr 14, 2020

Uh oh!

lukasolson left a comment

Uh oh!

Uh oh!

Uh oh!

cjcenizal left a comment •

edited

Loading

Uh oh!

kibanamachine commented Apr 19, 2020

Uh oh!

spalger commented Apr 20, 2020

Uh oh!

spalger commented Apr 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

lizozom commented Apr 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Apr 12, 2020

Uh oh!

lizozom commented Apr 14, 2020

Uh oh!

lukasolson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cjcenizal left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 19, 2020

💚 Build Succeeded

History

Uh oh!

spalger commented Apr 20, 2020

Uh oh!

spalger commented Apr 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lizozom commented Apr 12, 2020 •

edited

Loading

cjcenizal left a comment •

edited

Loading