Refactor saved object types to use namespaceType#63217
Merged
jportner merged 6 commits intoelastic:masterfrom Apr 16, 2020
Merged
Refactor saved object types to use namespaceType#63217jportner merged 6 commits intoelastic:masterfrom
namespaceType#63217jportner merged 6 commits intoelastic:masterfrom
Conversation
Remove `namespaceAgnostic` field that was deprecated in elastic#54605, use `namespaceType` instead.
jportner
commented
Apr 10, 2020
Comment on lines
-213
to
+208
| namespaceType?: SavedObjectsNamespaceType; | ||
| namespaceType: SavedObjectsNamespaceType; |
Contributor
Author
There was a problem hiding this comment.
Before #54605 was merged, the namespaceAgnostic field was required. Now that we are removing it, the namespaceType field should be required.
lizozom
reviewed
Apr 12, 2020
Contributor
|
ack: will review today |
pgayvallet
reviewed
Apr 14, 2020
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
👍 LGTM for platform changes. Thanks for the quick follow-up.
pgayvallet
approved these changes
Apr 14, 2020
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
Approval is better than comment 😄
Contributor
|
@elasticmachine merge upstream |
stephmilovic
approved these changes
Apr 16, 2020
Contributor
stephmilovic
left a comment
There was a problem hiding this comment.
LGTM on the changes to x-pack/plugins/case
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
timroes
approved these changes
Apr 16, 2020
Contributor
timroes
left a comment
There was a problem hiding this comment.
Reviewed Kibana App code only, code LGTM, haven't tested
jportner
added a commit
that referenced
this pull request
Apr 16, 2020
Remove `namespaceAgnostic` field that was deprecated in #54605, use `namespaceType` instead.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 17, 2020
* master: (40 commits) [APM]Upgrade apm-rum agent to latest version to fix full page reload (elastic#63723) add deprecation warning for legacy 3rd party plugins (elastic#62401) Migrate timelion vis (elastic#62819) Replacebad scope link with actual values (elastic#63444) Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) (elastic#63111) [SIEM] Threat hunting enhancements: Filter for/out value, Show top field, Copy to Clipboard, Draggable chart legends (elastic#61207) [Maps] fix term join agg key collision (elastic#63324) [Ingest] Fix agent config key sorting (elastic#63488) [Monitoring] Fixed server response errors (elastic#63181) update elastic charts to 18.3.0 (elastic#63732) Start services (elastic#63720) [APM] Encode spaces when creating ML job (elastic#63683) Uptime 7.7 docs (elastic#62228) [DOCS] Updates remote cluster and ccr docs (elastic#63517) [Maps] Add 3rd party vector tile support (elastic#62084) [Endpoint][EPM] Retrieve Index Pattern from Ingest Manager (elastic#63016) [Endpoint] Host Details Policy Response Panel (elastic#63518) [Uptime] Certificate expiration threshold settings (elastic#63682) Refactor saved object types to use `namespaceType` (elastic#63217) [SIEM][CASE] Create comments sequentially (elastic#63692) ...
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
namespaceAgnosticfield that was deprecated in #54605, usenamespaceTypeinstead.Resolves #60981.