Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard)#63111
Merged
VladLasitsa merged 12 commits intoelastic:masterfrom Apr 17, 2020
Conversation
alexwizp
reviewed
Apr 9, 2020
...ent/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.test.tsx
Show resolved
Hide resolved
alexwizp
reviewed
Apr 9, 2020
...ent/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.test.tsx
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Apr 9, 2020
...nagement/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.tsx
Show resolved
Hide resolved
16 tasks
alexwizp
reviewed
Apr 14, 2020
...ent/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.test.tsx
Show resolved
Hide resolved
alexwizp
reviewed
Apr 14, 2020
...nagement/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
alexwizp
approved these changes
Apr 15, 2020
Contributor
Author
|
@elasticmachine merge upstream |
mattkime
requested changes
Apr 16, 2020
Contributor
mattkime
left a comment
There was a problem hiding this comment.
Looks good aside from one requested change.
...nagement/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine merge upstream |
…rn_wizard)' into elastic#51322(create_index_pattern_wizard)
mattkime
requested changes
Apr 16, 2020
Contributor
mattkime
left a comment
There was a problem hiding this comment.
A couple of items were overlooked in the removal of indexPatternCreationType from state
...nagement/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.tsx
Outdated
Show resolved
Hide resolved
...nagement/sections/index_patterns/create_index_pattern_wizard/create_index_pattern_wizard.tsx
Outdated
Show resolved
Hide resolved
mattkime
approved these changes
Apr 16, 2020
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Apr 17, 2020
…ate_index_pattern_wizard) (elastic#63111) * Migrated create_index_pattern_wizard and its tests to typescript * Fixed types * Fixed some comments * Fixed comments * Fixed types * Fixed types * Fixed snapshot * Removed indexPatternCreationType from state. * Fixed comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 17, 2020
* master: (40 commits) [APM]Upgrade apm-rum agent to latest version to fix full page reload (elastic#63723) add deprecation warning for legacy 3rd party plugins (elastic#62401) Migrate timelion vis (elastic#62819) Replacebad scope link with actual values (elastic#63444) Index pattern management UI -> TypeScript and New Platform Ready (create_index_pattern_wizard) (elastic#63111) [SIEM] Threat hunting enhancements: Filter for/out value, Show top field, Copy to Clipboard, Draggable chart legends (elastic#61207) [Maps] fix term join agg key collision (elastic#63324) [Ingest] Fix agent config key sorting (elastic#63488) [Monitoring] Fixed server response errors (elastic#63181) update elastic charts to 18.3.0 (elastic#63732) Start services (elastic#63720) [APM] Encode spaces when creating ML job (elastic#63683) Uptime 7.7 docs (elastic#62228) [DOCS] Updates remote cluster and ccr docs (elastic#63517) [Maps] Add 3rd party vector tile support (elastic#62084) [Endpoint][EPM] Retrieve Index Pattern from Ingest Manager (elastic#63016) [Endpoint] Host Details Policy Response Panel (elastic#63518) [Uptime] Certificate expiration threshold settings (elastic#63682) Refactor saved object types to use `namespaceType` (elastic#63217) [SIEM][CASE] Create comments sequentially (elastic#63692) ...
VladLasitsa
added a commit
that referenced
this pull request
Apr 17, 2020
…ate_index_pattern_wizard) (#63111) (#63819) * Migrated create_index_pattern_wizard and its tests to typescript * Fixed types * Fixed some comments * Fixed comments * Fixed types * Fixed types * Fixed snapshot * Removed indexPatternCreationType from state. * Fixed comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #51322
Summary
Migrated create_index_pattern_wizard and its tests to typescript
For maintainers