[APM] Prevent error rate alert trigger from rendering NaN#62754
Merged
dgieselaar merged 3 commits intoelastic:masterfrom Apr 7, 2020
Merged
[APM] Prevent error rate alert trigger from rendering NaN#62754dgieselaar merged 3 commits intoelastic:masterfrom
dgieselaar merged 3 commits intoelastic:masterfrom
Conversation
| ...alertParams | ||
| }; | ||
|
|
||
| const threshold = isFinite(alertParams.threshold) |
Contributor
There was a problem hiding this comment.
Shouldn't we use params.threshold instead of alertParams. threshold ?
Contributor
Author
There was a problem hiding this comment.
yes! thanks. I see I mixed it up before as well. Fixed.
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Apr 7, 2020
) * [APM] Prevent error rate alert trigger from rendering NaN Closes elastic#62458. * Use params instead of alertParams
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Apr 7, 2020
) * [APM] Prevent error rate alert trigger from rendering NaN Closes elastic#62458. * Use params instead of alertParams
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 7, 2020
* master: [APM] Change custom link from EuiListGroupItem to EuiLink (elastic#62742) [Remote Clusters] Update callout and move server_name field (elastic#62352) Removes Pitch Presentation Template from Canvas (elastic#62688) FTR: Enable w3c for chromedriver (elastic#62542) [ML] Disable functional tests [ILM] Skip failing API integration test (elastic#62779) [SIEM] Update beat doc (elastic#61902) [Search] Properly add slash preceding path in async search (elastic#62722) [APM] make sure environment query is correct for service maps… (elastic#62764) Add service map icon for rum-js agent type (elastic#62721) [APM] Service map - fixes irrelevant services on data refresh (elastic#62750) [APM] Service map - Fix taxi edge arrow orientation (elastic#62741) [APM] Prevent error rate alert trigger from rendering NaN (elastic#62754) [EPM] Store map visualizations from the package registry and use saved object ID (elastic#62059) [Alerting] for email action, set tls.rejectUnauthorized: false when secure: false (elastic#62380)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62458.