FTR: Enable w3c for chromedriver#62542
Merged
dmlemeshko merged 13 commits intoelastic:masterfrom Apr 7, 2020
Merged
Conversation
dmlemeshko
commented
Apr 5, 2020
| { location: el, offset: { x: 200, y: 20 } }, | ||
| { location: el, offset: { x: 400, y: 30 } } | ||
| { location: el, offset: { x: -300, y: 20 } }, | ||
| { location: el, offset: { x: -100, y: 30 } } |
Contributor
Author
There was a problem hiding this comment.
This change tested on both chromedriver and msedgedriver
dmlemeshko
commented
Apr 5, 2020
dmlemeshko
commented
Apr 5, 2020
| await browser.get(appUrl); | ||
| // accept alert if it pops up | ||
| const alert = await browser.getAlert(); | ||
| await alert?.accept(); |
Contributor
Author
There was a problem hiding this comment.
According to W3C spec driver.get call is not failing if alert pops up as before, but we need to accept it in order to proceed.
Contributor
Author
|
@elasticmachine merge upstream |
…/kibana into ftr/switch-chrome-to-w3c-mode
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_snapshots·js.dashboard app using current data dashboard snapshots compare area chart snapshotStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
LeeDr
approved these changes
Apr 7, 2020
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - tested the discover tests with brushing the histogram on Chrome and Firefox on my local Windows.
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Apr 7, 2020
* enable w3c for chrome * update maps tests * update maps tests * update common_page * Revert "update maps tests" This reverts commit 31f43fd. * revert changes to maps tests * undo after removal * update expect range to pass on Windows, unskip tests for Firefox * print out value for discover brushing test * log first timestamp Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Apr 7, 2020
* enable w3c for chrome * update maps tests * update maps tests * update common_page * Revert "update maps tests" This reverts commit 31f43fd. * revert changes to maps tests * undo after removal * update expect range to pass on Windows, unskip tests for Firefox * print out value for discover brushing test * log first timestamp Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 7, 2020
* master: [APM] Change custom link from EuiListGroupItem to EuiLink (elastic#62742) [Remote Clusters] Update callout and move server_name field (elastic#62352) Removes Pitch Presentation Template from Canvas (elastic#62688) FTR: Enable w3c for chromedriver (elastic#62542) [ML] Disable functional tests [ILM] Skip failing API integration test (elastic#62779) [SIEM] Update beat doc (elastic#61902) [Search] Properly add slash preceding path in async search (elastic#62722) [APM] make sure environment query is correct for service maps… (elastic#62764) Add service map icon for rum-js agent type (elastic#62721) [APM] Service map - fixes irrelevant services on data refresh (elastic#62750) [APM] Service map - Fix taxi edge arrow orientation (elastic#62741) [APM] Prevent error rate alert trigger from rendering NaN (elastic#62754) [EPM] Store map visualizations from the package registry and use saved object ID (elastic#62059) [Alerting] for email action, set tls.rejectUnauthorized: false when secure: false (elastic#62380)
dmlemeshko
added a commit
that referenced
this pull request
Apr 7, 2020
* enable w3c for chrome * update maps tests * update maps tests * update common_page * Revert "update maps tests" This reverts commit 31f43fd. * revert changes to maps tests * undo after removal * update expect range to pass on Windows, unskip tests for Firefox * print out value for discover brushing test * log first timestamp Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dmlemeshko
added a commit
that referenced
this pull request
Apr 7, 2020
* enable w3c for chrome * update maps tests * update maps tests * update common_page * Revert "update maps tests" This reverts commit 31f43fd. * revert changes to maps tests * undo after removal * update expect range to pass on Windows, unskip tests for Firefox * print out value for discover brushing test * log first timestamp Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Apr 9, 2020
* enable w3c for chrome * update maps tests * update maps tests * update common_page * Revert "update maps tests" This reverts commit 31f43fd. * revert changes to maps tests * undo after removal * update expect range to pass on Windows, unskip tests for Firefox * print out value for discover brushing test * log first timestamp Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dmlemeshko
added a commit
that referenced
this pull request
Apr 12, 2020
* FTR: Enable w3c for chromedriver (#62542) * enable w3c for chrome * update maps tests * update maps tests * update common_page * Revert "update maps tests" This reverts commit 31f43fd. * revert changes to maps tests * undo after removal * update expect range to pass on Windows, unskip tests for Firefox * print out value for discover brushing test * log first timestamp Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * remove unused function * fix common page PO Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #34963 and unblock #61684
Webdriver became W3C standard, which means browser vendors implement drivers according the specification to have exact the same behaviour.
Recently we were running Chrome and IE drivers in non-W3C compliance mode (old way since Leadfoot times) and only Firefox in W3C mode. As the result, to make things work we had to split the driver logic like
Sometimes we had to split tests logic to support multiple drivers in different modes or even skip them (e.g.
skipFirefoxtag).The new chromium-based msedgedriver is fully W3C compatible and in w3c mode chromedriver works exactly the same way. It really makes sense to convert chromedriver run since we plan to drop IE 11 support and IEdriver from FTR, and we will be running all the drivers in W3C compliance mode.
Checklist
Delete any items that are not applicable to this PR.
For maintainers