Skip to content

Add pipeline support to Ingest API#6070

Merged
Bargs merged 8 commits intoelastic:feature/ingestfrom
Bargs:ingest/pipelineIngestAPI
Feb 8, 2016
Merged

Add pipeline support to Ingest API#6070
Bargs merged 8 commits intoelastic:feature/ingestfrom
Bargs:ingest/pipelineIngestAPI

Conversation

@Bargs
Copy link
Copy Markdown
Contributor

@Bargs Bargs commented Feb 2, 2016

Replaces #6034 since merging into master would break tests due to dependency on ES master.

Requires #5656 and a build of Elasticsearch with the ingest functionality (at time of writing, a build of the master branch)

This PR adds pipeline support to the ingest API.

If you like Postman, import this collection with example requests to play around with.

An array of processors can be included under a pipeline key in the JSON payload provided to the POST endpoint. The Kibana ingest API will use this list of processors to create an ES ingest pipeline. As a result, you'll need to test this PR against a build from ES master (or clone the ES repo and run gradle run).

I've created a ticket to add API tests once Kibana master has been updated to track ES master (#6035).

@Bargs Bargs added the review label Feb 5, 2016
@Bargs
Copy link
Copy Markdown
Contributor Author

Bargs commented Feb 5, 2016

@jbudz this is the new PR targeting the feature/ingest branch instead of master. If you run this PR against a fresh installation of Elasticsearch master everything in the API should work. Tests will fail since I only made the minimum change to get Kibana to start up with ES master, but that's why I'm targeting the feature/ingest branch so that I can continue working on features that need this API.

I updated the code so that TypeError you were seeing should throw a more user friendly 500 error now. If you have the time, I'd appreciate any other feedback you have!

@jbudz
Copy link
Copy Markdown
Contributor

jbudz commented Feb 8, 2016

LGTM

@jbudz jbudz assigned Bargs and unassigned jbudz Feb 8, 2016
Bargs pushed a commit that referenced this pull request Feb 8, 2016
Add pipeline support to Ingest API
@Bargs Bargs merged commit 1c7227e into elastic:feature/ingest Feb 8, 2016
@Bargs Bargs mentioned this pull request Feb 12, 2016
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants