[es] upgrade to master by spalger · Pull Request #5656 · elastic/kibana

spalger · 2015-12-11T23:56:20Z

Breaking Changes doc: https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-3.0.html

upgrade to master - be358d8
fix field fetching, impacted by 3.0 Mapping API field wildcard not working? elasticsearch#15782
- stop sending search_type=count - 1bece49
remove filtered queries - dc4dec2
in order to specify the language for a script nest { script, lang } under the script key - 904d0e2
- remove query filter
ip filter needs different format?
upgrade scenario master to use new mapping syntax

LeeDr · 2016-01-04T15:46:36Z

jenkins, test it

Bargs · 2016-02-04T23:38:06Z

@spalger is this still actively being worked on? Is there anything I could do to help move it along? Getting this PR merged would be great for the feature/ingest branch which relies on features in ES master.

since es 3.0 removed it, and we are trying to upgrade... needs to go!

…compat

This reverts commit 6f73fc0dbb1609637c16f4fae9b282adfd3fc262.

This reverts commit f68235db55a6d11dea1ef145446a75cc24cf84e2.

This reverts commit 904d0e2e9b31b380e4e39b36d11c50b85286dbd4.

This reverts commit dc4dec2.

This reverts commit 5a3b9d402c844ec32ea48a98e68893cb137abc30.

(cherry picked from commit f4e3226)

w33ble · 2016-02-08T20:11:59Z

The changes look good and all, but I'd like to run this against master and verify functionality myself before I give you a seal of approval. Unfortunately, the configuration I need to run ES is currently broken in master, so I'm waiting on fixes before I can test this out.

epixa · 2016-02-08T20:13:02Z

I killed this jenkins job because it had a bunch of failures and was beginning to time out.

Bargs · 2016-02-08T21:12:39Z

Getting the following error when trying to load Discover with a scripted field added to the index pattern:

Error: [parsing_exception] Unknown key for a VALUE_STRING in [lang]., with { line=1 col=704 }
    at respond (https://localhost:5601/flu/bundles/kibana.bundle.js?v=8467:69480:16)
    at checkRespForFailure (https://localhost:5601/flu/bundles/kibana.bundle.js?v=8467:69439:8)
    at https://localhost:5601/flu/bundles/kibana.bundle.js?v=8467:67957:8
    at processQueue (https://localhost:5601/flu/bundles/commons.bundle.js?v=8467:37112:29)
    at https://localhost:5601/flu/bundles/commons.bundle.js?v=8467:37128:28
    at Scope.$eval (https://localhost:5601/flu/bundles/commons.bundle.js?v=8467:38356:29)
    at Scope.$digest (https://localhost:5601/flu/bundles/commons.bundle.js?v=8467:38167:32)
    at Scope.$apply (https://localhost:5601/flu/bundles/commons.bundle.js?v=8467:38464:25)
    at done (https://localhost:5601/flu/bundles/commons.bundle.js?v=8467:32913:48)
    at completeRequest (https://localhost:5601/flu/bundles/commons.bundle.js?v=8467:33111:8)

Bargs · 2016-02-08T21:30:01Z

Other than the above error, I haven't seen any glaring issues.

Bargs · 2016-02-08T21:36:41Z

src/plugins/elasticsearch/index.js

        }).default(),
-        apiVersion: string().default('2.0'),
-        engineVersion: string().valid('^2.1.0').default('^2.1.0')
+        apiVersion: Joi.string().default('master'),


How does the elasticsearch js client interpret master being passed as the API version? Wouldn't we still want to pin each version of Kibana to a specific version of the ES API?

Well, since the elasticsearch installation is pinned to master we need to use the same API version. The API in use in es master isn't shipping in any other version. "master" is the only option.

Maybe I missed a conversation about how all this is going to be handled. Is the plan to replace master everywhere with the correct version of ES when we cut a release?

We'd replace master with a specific version whenever we created the version branch, which generally happens at feature freeze.

Got it, makes sense

…icsearch/master

This reverts commit c6da4eb.

…icsearch/master

[es] upgrade to master

spalger added review v5.0.0 and removed review labels Dec 11, 2015

spalger mentioned this pull request Jan 5, 2016

[courier] don't send search_type=count #5821

Closed

spalger force-pushed the upgrade/elasticsearch/master branch from 5372fc2 to be358d8 Compare January 5, 2016 23:09

LeeDr mentioned this pull request Jan 20, 2016

Fix automated test data load remove deprecated multi-field use #5918

Closed

spalger self-assigned this Feb 1, 2016

This was referenced Feb 1, 2016

Add pipeline support to Ingest API #6034

Closed

Add pipeline support to Ingest API #6070

Merged

spalger and others added 17 commits February 5, 2016 10:22

[es] upgrade to master

da5acc4

[courier] don't send search_type=count

9ad8239

since es 3.0 removed it, and we are trying to upgrade... needs to go!

[courier] remove use of filtered_query

ff832a6

[scriptedFields] nest script and lang under script param

05392a7

[webpack] enforce using elasticsearch-browser

811991b

[esjs] update

d5e76b0

[elasticsearch/client] use bluebird for promises for better backward …

1e507a9

…compat

[elasticsearch] getFieldMapping takes fields not field now

451e7fc

removing query object wrapper

23aae7e

[filterManager] remove query wrapper

b6c057c

Revert "[filterManager] remove query wrapper"

ea57429

This reverts commit 6f73fc0dbb1609637c16f4fae9b282adfd3fc262.

Revert "removing query object wrapper"

6a5e038

This reverts commit f68235db55a6d11dea1ef145446a75cc24cf84e2.

Revert "[scriptedFields] nest script and lang under script param"

c60d080

This reverts commit 904d0e2e9b31b380e4e39b36d11c50b85286dbd4.

Revert "[courier] remove use of filtered_query"

02d6fd5

This reverts commit dc4dec2.

Revert "Revert "[courier] remove use of filtered_query""

b1cfa20

This reverts commit 5a3b9d402c844ec32ea48a98e68893cb137abc30.

[courier/DataSource] style improvements

15c94b4

[courier] translate filters and filter aggs to work with es master

7aee4a5

spalger force-pushed the upgrade/elasticsearch/master branch from a008cad to 7aee4a5 Compare February 5, 2016 17:25

[ScenarioManager] use new multi-field syntax

410029d

Allow exists filter for unindexed fields, but not meta fields

c6da4eb

(cherry picked from commit f4e3226)

spalger added 2 commits February 8, 2016 14:05

Merge branch 'fix/failTestOnBadBulk' into upgrade/elasticsearch/master

10e97a4

[scenarioManager] do not mix index:analyzed and doc_values:true

728fbdb

Bargs reviewed Feb 8, 2016
View reviewed changes

spalger added 3 commits February 8, 2016 15:33

Merge branch 'master' of github.com:elastic/kibana into upgrade/elast…

f200db7

…icsearch/master

Revert "Allow exists filter for unindexed fields, but not meta fields"

d1387c7

This reverts commit c6da4eb.

[scriptedFields] use the comprehensive syntax for compat

2486b1d

spalger removed the review label Feb 8, 2016

[scenarioManager] use index:true rather than removal from 8d0d581

9a4bb32

spalger assigned Bargs and unassigned spalger Feb 8, 2016

spalger added the review label Feb 8, 2016

spalger unassigned Bargs Feb 8, 2016

spalger removed the review label Feb 8, 2016

spalger added 3 commits February 8, 2016 16:14

[courier/segmented] remove search_type=count again (bad merge?)

135188e

Merge branch 'master' of github.com:elastic/kibana into upgrade/elast…

be40e98

…icsearch/master

[es-browser] fix load order issues

b9e8a86

spalger added the review label Feb 9, 2016

spalger assigned tsullivan Feb 9, 2016

spalger added a commit that referenced this pull request Feb 9, 2016

Merge pull request #5656 from spalger/upgrade/elasticsearch/master

4e27267

[es] upgrade to master

spalger merged commit 4e27267 into elastic:master Feb 9, 2016

spalger deleted the upgrade/elasticsearch/master branch February 25, 2016 22:47

epixa added v5.0.0-alpha1 and removed v5.0.0-alpha1 labels Mar 31, 2016

spalger mentioned this pull request Dec 20, 2016

[4.x] Bump elasticsearch-js version to the latest stable #7210

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[es] upgrade to master#5656

[es] upgrade to master#5656
spalger merged 35 commits intoelastic:masterfrom
spalger:upgrade/elasticsearch/master

spalger commented Dec 11, 2015 •

edited by jbudz

Loading

Uh oh!

LeeDr commented Jan 4, 2016

Uh oh!

Bargs commented Feb 4, 2016

Uh oh!

w33ble commented Feb 8, 2016

Uh oh!

epixa commented Feb 8, 2016

Uh oh!

Bargs commented Feb 8, 2016

Uh oh!

Bargs commented Feb 8, 2016

Uh oh!

Bargs Feb 8, 2016

Uh oh!

spalger Feb 8, 2016

Uh oh!

Bargs Feb 8, 2016

Uh oh!

epixa Feb 8, 2016

Uh oh!

Bargs Feb 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

spalger commented Dec 11, 2015 • edited by jbudz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LeeDr commented Jan 4, 2016

Uh oh!

Bargs commented Feb 4, 2016

Uh oh!

w33ble commented Feb 8, 2016

Uh oh!

epixa commented Feb 8, 2016

Uh oh!

Bargs commented Feb 8, 2016

Uh oh!

Bargs commented Feb 8, 2016

Uh oh!

Bargs Feb 8, 2016

Choose a reason for hiding this comment

Uh oh!

spalger Feb 8, 2016

Choose a reason for hiding this comment

Uh oh!

Bargs Feb 8, 2016

Choose a reason for hiding this comment

Uh oh!

epixa Feb 8, 2016

Choose a reason for hiding this comment

Uh oh!

Bargs Feb 9, 2016

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

spalger commented Dec 11, 2015 •

edited by jbudz

Loading