[SIEM] Skips 'config_open.ts' files from linter check#60248
Merged
MadameSheema merged 1 commit intoelastic:masterfrom Mar 16, 2020
Merged
[SIEM] Skips 'config_open.ts' files from linter check#60248MadameSheema merged 1 commit intoelastic:masterfrom
MadameSheema merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
FrankHassanabad
approved these changes
Mar 16, 2020
Contributor
FrankHassanabad
left a comment
There was a problem hiding this comment.
One line change! The best type of PR's!
LGTM
cnasikas
reviewed
Mar 16, 2020
| 'x-pack/test/functional/apps/**/*.js', | ||
| 'x-pack/legacy/plugins/apm/**/*.js', | ||
| 'test/*/config.ts', | ||
| 'test/*/config_open.ts', |
Member
There was a problem hiding this comment.
@FrankHassanabad @MadameSheema What do you think is better? Exclude all config files ('test/*/config*.ts',) or only the config_open.ts?
Contributor
Author
There was a problem hiding this comment.
I did it that way because if we use the rule you are suggesting we are going to skip all config files. As this config files are usually written by Kibana team and we are creating a new type, I just added the same rule but with the new config file so I don't want to skip the check for more things.
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
MadameSheema
added a commit
to MadameSheema/kibana
that referenced
this pull request
Mar 16, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 16, 2020
* master: (40 commits) skips 'config_open.ts' files from linter check (elastic#60248) [Searchprofiler] Spacing between rendered shards (elastic#60238) Add UiSettings validation & Kibana default route redirection (elastic#59694) [SIEM][CASE] Change configuration button (elastic#60229) [Step 1][App Arch] Saved object migrations from kibana plugin to new platform (elastic#59044) adds new test (elastic#60064) [Uptime] Index Status API to Rest (elastic#59657) [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950) [NP] Graph migration (elastic#59409) [ML] Clone analytics job (elastic#59791) Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202) Handle improperly defined Watcher Logging Action text parameter. (elastic#60169) Move select range trigger to uiActions (elastic#60168) [SIEM][CASES] Configure cases: Final (elastic#59358) Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153) [siem/cypress] update junit filename to be picked up by runbld (elastic#60156) OSS logic added to test environment (elastic#60134) Move canvas setup into app mount (elastic#59926) enable triggers_actions_ui plugin by default (elastic#60137) Expose Elasticsearch from start and deprecate from setup (elastic#59886) ...
MadameSheema
added a commit
that referenced
this pull request
Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we are skipping from the linter check all config_open files since this is following the same structure as the config.ts files and skipped as well.
Once this is merged this should unlock: #59880