[App Arch] migrate legacy CSS to new platform (core_plugins/kibana_react)#59882
Merged
VladLasitsa merged 13 commits intoelastic:masterfrom Mar 24, 2020
Merged
[App Arch] migrate legacy CSS to new platform (core_plugins/kibana_react)#59882VladLasitsa merged 13 commits intoelastic:masterfrom
VladLasitsa merged 13 commits intoelastic:masterfrom
Conversation
Contributor
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
alexwizp
reviewed
Mar 12, 2020
| export * from './table_list_view'; | ||
| export * from './split_panel'; | ||
| export { Markdown, MarkdownSimple } from './markdown'; | ||
| export * from './markdown'; |
Contributor
There was a problem hiding this comment.
Please revert { Markdown, MarkdownSimple }. We are trying to don't use *
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
ci is red due to: |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
alexwizp
approved these changes
Mar 20, 2020
alexwizp
requested changes
Mar 20, 2020
Contributor
alexwizp
left a comment
There was a problem hiding this comment.
Looks like we still import Markdown/MarkdownSimple from the /../kibana_react/public' folder
At least I found one place with that wrong import. see: src/legacy/core_plugins/vis_type_timeseries/public/components/vis_types/markdown/vis.js
alexwizp
approved these changes
Mar 20, 2020
Contributor
alexwizp
left a comment
There was a problem hiding this comment.
Sorry, I was wrong 😄 Code LGTM!
poffdeluxe
approved these changes
Mar 20, 2020
Contributor
poffdeluxe
left a comment
There was a problem hiding this comment.
Canvas changes work great!
cchaos
approved these changes
Mar 20, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
The SASS file moves LGTM, so long as the plugin is correctly building compiling the CSS.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Mar 24, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
KibanaApp Codeowner file LGTM!
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Mar 24, 2020
…act) (elastic#59882) * Migrate markdown styles to the new platform * Removed unused import * Update index.ts * Removed not need layer * Fixed paths Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 24, 2020
* master: (34 commits) [APM] add service map config options to legacy plugin (elastic#61002) [App Arch] migrate legacy CSS to new platform (core_plugins/kibana_react) (elastic#59882) Migrated styles for "share" plugin to new platform (elastic#59981) [ML] Module setup with dynamic model memory estimation (elastic#60656) Drilldowns (elastic#59632) Upgrade mocha dev-dependency from 6.2.2 to 7.1.1 (elastic#60779) [SIEM] Overview: Recent cases widget (elastic#60993) [ML] Functional tests - stabilize df analytics clone tests (elastic#60497) [SIEM] Updates process and TLS tables to use ECS 1.5 fields (elastic#60854) Migrate doc view part of discover (elastic#58094) Revert "[APM] Collect telemetry about data/API performance (elastic#51612)" fix(NA): log rotation watchers usage (elastic#60956) [SIEM] [CASES] Build lego blocks case details view (elastic#60864) Create Painless Lab app (elastic#57538) [SIEM] Move Timeline Template field to first step of rule creation (elastic#60840) [Reporting/New Platform Migration] Use a new config service on server-side (elastic#55882) [Alerting] allow email action to not require auth (elastic#60839) [Maps] Default ES document layer scaling type to clusters and show scaling UI in the create wizard (elastic#60668) [APM] Collect telemetry about data/API performance (elastic#51612) Implement Kibana Login Selector (elastic#53010) ...
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of: #55493
Summary
Here's a list of app arch legacy items I've found so far which contain some scss (be sure to look around for anything I may have missed):
Checklist
Delete any items that are not applicable to this PR.
For maintainers