Drilldowns by streamich · Pull Request #59632 · elastic/kibana

streamich · 2020-03-09T09:31:33Z

Summary

Partially addresses #42845
Closes #59973

This PR adds initial drilldowns feature to Kibana.

Drilldowns are hidden behind a feature flag, to enable add to your kibana.yml:

xpack.dashboardEnhanced.drilldowns.enabled: true

After merging this PR we need to also merge Dashboard-to-Dashboard and functional test PR: #60087

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

* feat: 🎸 add DynamicAction and FactoryAction types * feat: 🎸 add Mutable<T> type to @kbn/utility-types * feat: 🎸 add ActionInternal and ActionContract * chore: 🤖 remove unused file * feat: 🎸 improve action interfaces * docs: ✏️ add JSDocs * feat: 🎸 simplify ui_actions interfaces * fix: 🐛 fix TypeScript types * feat: 🎸 add AbstractPresentable interface * feat: 🎸 add AbstractConfigurable interface * feat: 🎸 use AbstractPresentable in ActionInternal * test: 💍 fix ui_actions Jest tests * feat: 🎸 add state container to action * perf: ⚡️ convert MenuItem to React component on Action instance * refactor: 💡 rename AbsractPresentable -> Presentable * refactor: 💡 rename AbstractConfigurable -> Configurable * feat: 🎸 add Storybook to ui_actions * feat: 🎸 add <ErrorConfigureAction> component * feat: 🎸 improve <ConfigureAction> component * chore: 🤖 use .story file extension prefix for Storybook * feat: 🎸 improve <ErrorConfigureAction> component * feat: 🎸 show error if dynamic action has CollectConfig missing * feat: 🎸 render sample action configuration component * feat: 🎸 connect action config to <ConfigureAction> * feat: 🎸 improve <ConfigureAction> stories * test: 💍 add ActionInternal serialize/deserialize tests * feat: 🎸 add ActionContract * feat: 🎸 split action Context into Execution and Presentation * fix: 🐛 fix TypeScript error * refactor: 💡 extract state container hooks to module scope * docs: ✏️ fix typos * chore: 🤖 remove Mutable<t> type * test: 💍 don't cast to any getActions() function * style: 💄 avoid using unnecessary types * chore: 🤖 address PR review comments * chore: 🤖 rename ActionContext generic * chore: 🤖 remove order from state container * chore: 🤖 remove deprecation notice on getHref * test: 💍 fix tests after order field change * remove comments Co-authored-by: Matt Kime <matt@mattki.me> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* fix: 🐛 fix TypeScript error * feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger * fix: 🐛 correctly order context menu items * fix: 🐛 set correct order on drilldown flyout actions * fix: 🐛 clean up context menu building functions * feat: 🎸 add context menu separator action

…tead of mocks

* feat: 🎸 add dashboard_enhanced plugin to x-pack * feat: 🎸 improve context menu separator * feat: 🎸 move drilldown flyout actions to dashboard_enhanced * fix: 🐛 fix exports from ui_actions plugin

# Conflicts: # x-pack/plugins/drilldowns/public/service/drilldown_service.ts

…diate component

streamich · 2020-03-10T12:28:43Z

retest

Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.

andreadelrio · 2020-03-23T17:04:27Z

@streamich thanks for making that change. Looks a bit cleaner

andreadelrio

LGTM

mdefazio

Thanks for the fixes!

streamich · 2020-03-23T17:35:05Z

@elasticmachine merge upstream

ppisljar

LGTM

kibanamachine · 2020-03-23T21:00:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6cd07c5

History

💚 Build #35520 succeeded 78e64d6
💚 Build #35491 succeeded 2b162e8
💚 Build #35347 succeeded 29ee51c
💚 Build #35303 succeeded 0d076d7
💚 Build #35279 succeeded d10aa7b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

joshdover

LGTM, but I think you to regenerate the docs based on the API change to flyouts.

kertal

Codeowners files LGTM, didn't test

* master: (34 commits) [APM] add service map config options to legacy plugin (elastic#61002) [App Arch] migrate legacy CSS to new platform (core_plugins/kibana_react) (elastic#59882) Migrated styles for "share" plugin to new platform (elastic#59981) [ML] Module setup with dynamic model memory estimation (elastic#60656) Drilldowns (elastic#59632) Upgrade mocha dev-dependency from 6.2.2 to 7.1.1 (elastic#60779) [SIEM] Overview: Recent cases widget (elastic#60993) [ML] Functional tests - stabilize df analytics clone tests (elastic#60497) [SIEM] Updates process and TLS tables to use ECS 1.5 fields (elastic#60854) Migrate doc view part of discover (elastic#58094) Revert "[APM] Collect telemetry about data/API performance (elastic#51612)" fix(NA): log rotation watchers usage (elastic#60956) [SIEM] [CASES] Build lego blocks case details view (elastic#60864) Create Painless Lab app (elastic#57538) [SIEM] Move Timeline Template field to first step of rule creation (elastic#60840) [Reporting/New Platform Migration] Use a new config service on server-side (elastic#55882) [Alerting] allow email action to not require auth (elastic#60839) [Maps] Default ES document layer scaling type to clusters and show scaling UI in the create wizard (elastic#60668) [APM] Collect telemetry about data/API performance (elastic#51612) Implement Kibana Login Selector (elastic#53010) ...

This reverts commit 5abb2c8.

kibanamachine · 2020-03-26T07:38:45Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59632 or prevent reminders by adding the backport:skip label.

Dosant and others added 2 commits March 9, 2020 09:57

Add drilldown wizard components

502a60a

streamich requested review from a team as code owners March 9, 2020 09:31

botelastic bot added the Feature:Drilldowns Embeddable panel Drilldowns label Mar 9, 2020

streamich and others added 2 commits March 9, 2020 12:09

Add basic ActionFactoryService. Pass data from it into components ins…

e145241

…tead of mocks

Dosant self-requested a review March 9, 2020 11:59

Dosant changed the title ~~Drilldowns~~ [wip] Drilldowns Mar 9, 2020

Dosant added the WIP Work in progress label Mar 9, 2020

streamich and others added 5 commits March 9, 2020 14:46

Dashboard x pack (#59653)

81e6bcb

* feat: 🎸 add dashboard_enhanced plugin to x-pack * feat: 🎸 improve context menu separator * feat: 🎸 move drilldown flyout actions to dashboard_enhanced * fix: 🐛 fix exports from ui_actions plugin

feat: 🎸 "implement" registerDrilldown() method

1f2cc4c

fix ConfigurableBaseConfig type

86885c4

Implement connected flyout_manage_drilldowns component

6463118

Merge branch 'master' of github.com:elastic/kibana into drilldowns

dcacf10

Dosant mentioned this pull request Mar 10, 2020

[wip][Drilldowns] Drilldown Wizard Components #59139

Closed

7 tasks

Dosant added 3 commits March 10, 2020 11:20

Merge branch 'master' of github.com:elastic/kibana into drilldowns

26dfa30

# Conflicts: # x-pack/plugins/drilldowns/public/service/drilldown_service.ts

Simplify connected flyout manage drilldowns component. Remove interme…

d3cd9e8

…diate component

Merge branch 'master' of github.com:elastic/kibana into drilldowns

1077518

clean up data-testid workaround in new components

840e873

streamich added v7.7.0 v8.0.0 release_note:enhancement labels Mar 10, 2020

streamich changed the title ~~[wip] Drilldowns~~ Drilldowns Mar 10, 2020

Connect welcome message to storage

f057979

Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.

Dosant removed their request for review March 10, 2020 13:52

Dosant assigned Dosant and streamich Mar 10, 2020

streamich requested a review from mdefazio March 23, 2020 17:07

andreadelrio approved these changes Mar 23, 2020

View reviewed changes

mdefazio approved these changes Mar 23, 2020

View reviewed changes

refactor: 💡 rename drilldownCount to eventCount

de6c6b1

streamich requested a review from ppisljar March 23, 2020 17:22

streamich added 3 commits March 23, 2020 18:23

style: 💄 remove any

88a81e2

Merge remote-tracking branch 'upstream/drilldowns' into drilldowns

af3777c

refactor: 💡 change how uiActions are passed to vis embeddable

e29030f

Merge branch 'master' into drilldowns

78e64d6

ppisljar approved these changes Mar 23, 2020

View reviewed changes

streamich added 2 commits March 23, 2020 19:57

chore: 🤖 catch up with master

00c42c4

style: 💄 remove unused import

6cd07c5

joshdover approved these changes Mar 23, 2020

View reviewed changes

kertal approved these changes Mar 24, 2020

View reviewed changes

streamich merged commit 5abb2c8 into master Mar 24, 2020

streamich mentioned this pull request Mar 24, 2020

[7.x] Drilldowns (#59632) #61032

Closed

mattkime added a commit to mattkime/kibana that referenced this pull request Mar 24, 2020

Revert "Drilldowns (elastic#59632)"

50a4037

This reverts commit 5abb2c8.

mattkime mentioned this pull request Mar 24, 2020

Revert "Drilldowns (#59632)" #61136

Merged

mattkime added a commit that referenced this pull request Mar 24, 2020

Revert "Drilldowns (#59632)" (#61136)

498abb4

This reverts commit 5abb2c8.

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 26, 2020

streamich added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 26, 2020

mattkime removed the v7.7.0 label Apr 13, 2020

timroes added the reverted label Apr 26, 2021

bhavyarm removed the release_note:enhancement label Feb 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drilldowns#59632

Drilldowns#59632
streamich merged 109 commits intomasterfrom
drilldowns

streamich commented Mar 9, 2020 •

edited

Loading

Uh oh!

streamich commented Mar 10, 2020

Uh oh!

andreadelrio commented Mar 23, 2020

Uh oh!

andreadelrio left a comment

Uh oh!

mdefazio left a comment

Uh oh!

streamich commented Mar 23, 2020

Uh oh!

ppisljar left a comment

Uh oh!

kibanamachine commented Mar 23, 2020

Uh oh!

joshdover left a comment

Uh oh!

kertal left a comment

Uh oh!

kibanamachine commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Conversation

streamich commented Mar 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

streamich commented Mar 10, 2020

Uh oh!

andreadelrio commented Mar 23, 2020

Uh oh!

andreadelrio left a comment

Choose a reason for hiding this comment

Uh oh!

mdefazio left a comment

Choose a reason for hiding this comment

Uh oh!

streamich commented Mar 23, 2020

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 23, 2020

💚 Build Succeeded

History

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

streamich commented Mar 9, 2020 •

edited

Loading