Alerting update route throttle property is missing#59580
Merged
YulNaumenko merged 5 commits intoelastic:masterfrom Mar 7, 2020
Merged
Alerting update route throttle property is missing#59580YulNaumenko merged 5 commits intoelastic:masterfrom
YulNaumenko merged 5 commits intoelastic:masterfrom
Conversation
…oute-throttle-missing # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
reviewed
Mar 6, 2020
| id: rule.id, | ||
| data: { | ||
| tags: addTags(tags ?? rule.tags, rule.params.ruleId, immutable ?? rule.params.immutable), | ||
| throttle: null, |
Contributor
There was a problem hiding this comment.
I think this will overwrite whatever value was previously stored. Do they always use null for throttle?
Contributor
Author
There was a problem hiding this comment.
Great catch! I will fix it based on siem proposal.
Contributor
There was a problem hiding this comment.
I'm wondering if you can pass undefined, and make use of elasticsearch partial update - this gets complicated when we use schema-config, and ESO's. Ugggh.
pmuellr
approved these changes
Mar 6, 2020
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
LGTM, except worried about the SIEM code that's setting throttle: null in the update, it will erase whatever throttle they had previously set.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Mar 7, 2020
* Added throttle property to update method of alertClient * Fixed failing snapshot * Fixed type check errors * Fixed null update for siem throttle
YulNaumenko
added a commit
that referenced
this pull request
Mar 7, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 9, 2020
* master: (154 commits) Add an optional authentication mode for HTTP resources (elastic#58589) Implement embeddable drilldown menu options (elastic#59232) [Alerting] "Create alert" graph visualization design improvements (elastic#59399) Alerting update route throttle property is missing (elastic#59580) [SIEM] Adds 'Load prebuilt rules' Cypress test (elastic#59529) Show error if field is not found during filter rendering (elastic#59298) Navigate back to discover app during test, because the saved search from the preceding test has major performance problems when used with this test (elastic#59571) Check for alert dialog when doing a force logout (elastic#59329) ensure fs deletes are not cwd dependent (elastic#59570) Empty message for APM service map (elastic#59518) [Drilldowns] <ActionWizard/> Component (elastic#59032) [Reporting] Improve the page exit error messages (elastic#59351) Ensure logged out starting state for tests that need it (elastic#59322) Hide input value from kbn-config-schema error messages (elastic#58843) [ML] Transforms: Migrate client plugin to NP. (elastic#59443) [ML] Disable failing functional tests [SIEM] Update Timeline to use the latest euiFlyoutBody style (elastic#59524) Temporarily remove the project mappings for PR labels (elastic#59493) [Alerting] replace index threshold graph usage of watcher APIs with new API (elastic#59385) [ML] Show view series link in anomalies table for machine_learning_user role (elastic#59549) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.