[Drilldowns] <ActionWizard/> Component by Dosant · Pull Request #59032 · elastic/kibana

Dosant · 2020-03-02T14:13:33Z

Summary

Part of #55291
New component to be used for:

Picking Action type to be created
Configuring Action type using dynamically provided action's configuration wizard

To try the component:

yarn storybook ui_actions

Follow-up PR integrates it into <FormCreateDrilldown/>: #59139

Also:

Adds basic scss support for storybook #storybook 📕 Storybook Roadmap #54707
Adds configuration for react-testing-library to use Kibana's data-test-subj as test-id instead of default data-test-id. This improvement didn't affect anyone, because no testId related queries have been used before across Kibana. - moved to [Unit Testing] Configure react-testing-library queries to use Kibana's data-test-subj instead of default data-testid #59445

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…s/action-factory-picker

elasticmachine · 2020-03-02T19:02:26Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

src/plugins/ui_actions/public/components/action_wizard/index.scss

mattkime

Might be a good idea to review css with he design team otherwise 👍

Dosant · 2020-03-03T08:32:49Z

@elasticmachine merge upstream

mistic

Changes in the files under code owners LGTM

cchaos

Just had some suggestions around the file architecture of the files and naming of classes and addressing questions of pixel values.

src/plugins/ui_actions/public/components/action_wizard/index.scss

src/plugins/ui_actions/public/components/action_wizard/action_wizard.tsx

src/plugins/ui_actions/public/components/action_wizard/index.scss

…s/action-factory-picker

Dosant · 2020-03-05T14:10:22Z

@elasticmachine merge upstream

Dosant · 2020-03-05T16:19:53Z

Fails because of

Adds configuration for react-testing-library to use Kibana's data-test-subj as test-id instead of default data-test-id. This improvement didn't affect anyone, because no testId related queries have been used before across Kibana.

After moving the code to x-pack

stacey-gammon

Once the ci issue is resolved, LGTM.

x-pack/plugins/advanced_ui_actions/public/components/action_wizard/action_wizard.tsx

x-pack/plugins/advanced_ui_actions/public/components/action_wizard/test_data.tsx

x-pack/plugins/advanced_ui_actions/public/components/action_wizard/action_wizard.tsx

extracted to separate pr

…s/action-factory-picker

kibanamachine · 2020-03-06T12:11:38Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4641454

History

💚 Build #31338 succeeded 9e040c1
💚 Build #31187 succeeded ea0d5c1
💔 Build #31083 failed e80538b
💚 Build #31061 succeeded 6d05a17
💛 Build #31052 was flaky f66922d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

andreadelrio

Sass and design changes LGTM.

kibanamachine · 2020-03-07T18:48:46Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2020-03-08T18:58:44Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

* master: (154 commits) Add an optional authentication mode for HTTP resources (elastic#58589) Implement embeddable drilldown menu options (elastic#59232) [Alerting] "Create alert" graph visualization design improvements (elastic#59399) Alerting update route throttle property is missing (elastic#59580) [SIEM] Adds 'Load prebuilt rules' Cypress test (elastic#59529) Show error if field is not found during filter rendering (elastic#59298) Navigate back to discover app during test, because the saved search from the preceding test has major performance problems when used with this test (elastic#59571) Check for alert dialog when doing a force logout (elastic#59329) ensure fs deletes are not cwd dependent (elastic#59570) Empty message for APM service map (elastic#59518) [Drilldowns] <ActionWizard/> Component (elastic#59032) [Reporting] Improve the page exit error messages (elastic#59351) Ensure logged out starting state for tests that need it (elastic#59322) Hide input value from kbn-config-schema error messages (elastic#58843) [ML] Transforms: Migrate client plugin to NP. (elastic#59443) [ML] Disable failing functional tests [SIEM] Update Timeline to use the latest euiFlyoutBody style (elastic#59524) Temporarily remove the project mappings for PR labels (elastic#59493) [Alerting] replace index threshold graph usage of watcher APIs with new API (elastic#59385) [ML] Show view series link in anomalies table for machine_learning_user role (elastic#59549) ...

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Dosant added 4 commits February 28, 2020 15:42

wip

de86fbd

Merge branch 'master' of github.com:elastic/kibana into dev/drilldown…

40ea973

…s/action-factory-picker

wip

21d8232

lint

bd601c6

streamich mentioned this pull request Mar 2, 2020

Drilldown UI components #55291

Closed

7 tasks

Dosant added 2 commits March 2, 2020 16:16

improve

9d181d3

fix

9e994a1

Dosant added the Team:AppArch label Mar 2, 2020

Dosant added Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 review labels Mar 2, 2020

Dosant marked this pull request as ready for review March 2, 2020 19:04

Dosant requested review from a team as code owners March 2, 2020 19:04

Dosant changed the title ~~[wip] [Drilldowns] ActionWizard Component~~ [Drilldowns] <ActionWizard/> Component Mar 2, 2020

Dosant requested review from mattkime, stacey-gammon and streamich March 2, 2020 19:04

Dosant commented Mar 2, 2020

View reviewed changes

src/plugins/ui_actions/public/components/action_wizard/index.scss Outdated Show resolved Hide resolved

mattkime approved these changes Mar 2, 2020

View reviewed changes

Merge branch 'master' into dev/drilldowns/action-factory-picker

caefe6e

Dosant mentioned this pull request Mar 3, 2020

[wip][Drilldowns] Drilldown Wizard Components #59139

Closed

7 tasks

mistic approved these changes Mar 3, 2020

View reviewed changes

cchaos reviewed Mar 3, 2020

View reviewed changes

@cchaos review

a08ea95

Dosant added 4 commits March 5, 2020 12:49

improve. make <ActionWizard/> stateless. Simplify interfaces.

1c37f65

Merge branch 'master' of github.com:elastic/kibana into dev/drilldown…

f66922d

…s/action-factory-picker

rename

ae07675

fix

6d05a17

Merge branch 'master' into dev/drilldowns/action-factory-picker

e80538b

Dosant mentioned this pull request Mar 5, 2020

Dynamic actions #58216

Merged

2 tasks

stacey-gammon approved these changes Mar 5, 2020

View reviewed changes

nit fixes

ea0d5c1

Dosant mentioned this pull request Mar 6, 2020

[Unit Testing] Configure react-testing-library queries to use Kibana's data-test-subj instead of default data-testid #59445

Merged

7 tasks

Dosant added 2 commits March 6, 2020 07:01

revert react testing library configuration

2f100c8

extracted to separate pr

Merge branch 'master' of github.com:elastic/kibana into dev/drilldown…

9e040c1

…s/action-factory-picker

Dosant requested review from andreadelrio and streamich and removed request for streamich March 6, 2020 08:12

Dosant added 2 commits March 6, 2020 11:26

Merge branch 'master' of github.com:elastic/kibana into dev/drilldown…

05367ec

…s/action-factory-picker

fix tests and use buttons instead of links

4641454

andreadelrio approved these changes Mar 6, 2020

View reviewed changes

Dosant merged commit 3c4cf56 into elastic:master Mar 6, 2020

Dosant mentioned this pull request Mar 6, 2020

[7.x] [Drilldowns] <ActionWizard/> Component (#59032) #59579

Merged

Dosant added a commit to Dosant/kibana that referenced this pull request Mar 6, 2020

[Drilldowns] <ActionWizard/> Component (elastic#59032)

c1d0a4d

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 7, 2020

Dosant added a commit that referenced this pull request Mar 9, 2020

[Drilldowns] <ActionWizard/> Component (#59032) (#59579)

84a7642

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 9, 2020

Conversation

Dosant commented Mar 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Mar 2, 2020

Uh oh!

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

Dosant commented Mar 3, 2020

Uh oh!

mistic left a comment

Choose a reason for hiding this comment

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dosant commented Mar 5, 2020

Uh oh!

Dosant commented Mar 5, 2020

Uh oh!

stacey-gammon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Mar 6, 2020

💚 Build Succeeded

History

Uh oh!

andreadelrio left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 7, 2020

Uh oh!

kibanamachine commented Mar 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Dosant commented Mar 2, 2020 •

edited

Loading