[Watcher UI] Not possible to edit a watch that was created with the API if the ID contains a dot#59383
Merged
jkelastic merged 5 commits intoelastic:masterfrom Mar 13, 2020
Conversation
|
💚 CLA has been signed |
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
|
@elasticmachine merge upstream |
alisonelizabeth
approved these changes
Mar 5, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
LGTM. Nice job @jkelastic!
Contributor
|
@jkelastic It looks like there is a jest test that needs to be updated as part of this change. Can you take a look? See https://github.com/elastic/kibana/blob/master/x-pack/plugins/watcher/__jest__/client_integration/watch_create_json.test.ts#L79. |
Contributor
|
@elasticmachine merge upstream |
ca3bc5f to
e545dd2
Compare
e545dd2 to
9d37bd5
Compare
spalger
reviewed
Mar 12, 2020
x-pack/plugins/watcher/__jest__/client_integration/watch_create_json.test.ts
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 16, 2020
…o alerting/view-in-app * 'alerting/view-in-app' of github.com:gmmorris/kibana: (33 commits) [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950) [NP] Graph migration (elastic#59409) [ML] Clone analytics job (elastic#59791) Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202) Handle improperly defined Watcher Logging Action text parameter. (elastic#60169) Move select range trigger to uiActions (elastic#60168) [SIEM][CASES] Configure cases: Final (elastic#59358) Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153) [siem/cypress] update junit filename to be picked up by runbld (elastic#60156) OSS logic added to test environment (elastic#60134) Move canvas setup into app mount (elastic#59926) enable triggers_actions_ui plugin by default (elastic#60137) Expose Elasticsearch from start and deprecate from setup (elastic#59886) [SIEM] [Case] Insert timeline bugfix and limit 25 cases (elastic#60136) [ML] Client side cut over (elastic#60100) Disable query bar on service map routes (elastic#60118) Move subscribe_with_scope to kibana_legacy (elastic#59781) [Ingest] Agent Config create with sys monitoring (elastic#60111) [Watcher UI] Not possible to edit a watch that was created with the API if the ID contains a dot (elastic#59383) Actually fetch functionbeat fields needed for telemetry (elastic#60054) ...
Contributor
|
@jkelastic can you backport this PR to |
jkelastic
added a commit
to jkelastic/kibana
that referenced
this pull request
Mar 16, 2020
…PI if the ID contains a dot (elastic#59383) * Add . period to the isRegex variable L34 * Undo ID2 back to ID , done for testing * Updated the Jest test message to include period * Undo exception message to include periods * Removed duplicate comments
Contributor
Author
Just complete this, thanks. |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #57636
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorials-
Unit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers
Release note
This PR fixes an issue where a user was unable to edit a watch with an ID that contained a dot.