[Vis Editor] Refactoring metrics axes#59135
Merged
sulemanof merged 15 commits intoelastic:masterfrom Mar 10, 2020
Merged
Conversation
…bana into fix-lint-vislib
# Conflicts: # .eslintrc.js
…ics_axes # Conflicts: # src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/category_axis_panel.tsx # src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx # src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/value_axis_options.tsx
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
maryia-lapata
approved these changes
Mar 5, 2020
Contributor
maryia-lapata
left a comment
There was a problem hiding this comment.
LGTM, tested locally on Chrome (Mac), it works as expected.
|
|
||
| const newAxes = [{ ...categoryAxis, labels: { ...categoryAxis.labels, rotate: 5 } }]; | ||
| expect(setValue).toBeCalledWith(CATEGORY_AXES, newAxes); | ||
| expect(setAxisLabel).toBeCalledWith('rotate', 5); |
Contributor
There was a problem hiding this comment.
Suggested change
| expect(setAxisLabel).toBeCalledWith('rotate', 5); | |
| expect(setAxisLabel).toBeCalledWith(ROTATE, 5); |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Mar 10, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested and everything still works for me, LGTM Nice improvement!
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 10, 2020
* master: Add a retry to dashboard test for a sometimes slow async operation (elastic#59600) [Endpoint] Sample data generator for endpoint app (elastic#58936) [Vis Editor] Refactoring metrics axes (elastic#59135) [DOCS] Changed Discover app to Discover (elastic#59769) [Metrics Alerts] Add support for search query and groupBy on alerts (elastic#59388) Enhancement - EUICodeEditor for Visualize JSON (elastic#58679) [ML] Transforms: Data grid fixes. (elastic#59538) [SIEM] Fix and consolidate handling of error responses in the client (elastic#59438) [Maps] convert tooltip classes to typescript (elastic#59589) [ML] Functional tests - re-activate date_nanos test (elastic#59649) Move canvas to use NP Expressions service (elastic#58387) Update misc dependencies (elastic#59542) [Unit Testing] Configure react-testing-library queries to use Kibana's data-test-subj instead of default data-testid (elastic#59445) [Console] Remove unused code (elastic#59554) [Logs / Metrics UI] Link handling / stop page reloads (elastic#58478) Add SavedObject management section registration in core (elastic#59291)
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Mar 11, 2020
* Fix TS for vislib * Fix TS * Revert table changes * Update unit test * Refactor code in metrics_axes Co-authored-by: maryia-lapata <mary.lopato@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sulemanof
added a commit
that referenced
this pull request
Mar 11, 2020
* Fix TS for vislib * Fix TS * Revert table changes * Update unit test * Refactor code in metrics_axes Co-authored-by: maryia-lapata <mary.lopato@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: maryia-lapata <mary.lopato@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactoring is based on optimization of rendering react components.
I tried to get rid of additional extra re-renders caused by changed props, which was never used in children components. This also includes fixing tests and types.
Checklist
Delete any items that are not applicable to this PR.
For maintainers