Enhancement - EUICodeEditor for Visualize JSON #58679
Merged
ThomThomson merged 15 commits intoelastic:masterfrom Mar 10, 2020
Merged
Enhancement - EUICodeEditor for Visualize JSON #58679ThomThomson merged 15 commits intoelastic:masterfrom
ThomThomson merged 15 commits intoelastic:masterfrom
Conversation
…ult json validation
…n/kibana into enhancement/jsonRawCodeEditor
…ch will be a false positive. Removed isValidJson from agg_types
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
myasonik
suggested changes
Mar 2, 2020
src/legacy/core_plugins/vis_default_editor/public/components/controls/raw_json.tsx
Outdated
Show resolved
Hide resolved
myasonik
approved these changes
Mar 4, 2020
Contributor
Author
|
@elasticmachine merge upstream |
src/legacy/core_plugins/vis_default_editor/public/components/controls/raw_json.tsx
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/vis_default_editor/public/components/controls/raw_json.tsx
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/vis_default_editor/public/components/controls/raw_json.tsx
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/vis_default_editor/public/components/controls/raw_json.tsx
Outdated
Show resolved
Hide resolved
maryia-lapata
approved these changes
Mar 6, 2020
Contributor
maryia-lapata
left a comment
There was a problem hiding this comment.
LGTM
with small comments
src/legacy/core_plugins/vis_default_editor/public/components/controls/raw_json.tsx
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/vis_default_editor/public/components/controls/raw_json.tsx
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/vis_default_editor/public/components/controls/raw_json.tsx
Show resolved
Hide resolved
timroes
reviewed
Mar 6, 2020
src/legacy/core_plugins/vis_default_editor/public/components/controls/raw_json.tsx
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lukeelmers
approved these changes
Mar 10, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
App arch code changes LGTM -- Thanks for taking the time to do this cleanup!
| isStringType, | ||
| isType, | ||
| isValidInterval, | ||
| isValidJson, |
Contributor
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 10, 2020
* master: Add a retry to dashboard test for a sometimes slow async operation (elastic#59600) [Endpoint] Sample data generator for endpoint app (elastic#58936) [Vis Editor] Refactoring metrics axes (elastic#59135) [DOCS] Changed Discover app to Discover (elastic#59769) [Metrics Alerts] Add support for search query and groupBy on alerts (elastic#59388) Enhancement - EUICodeEditor for Visualize JSON (elastic#58679) [ML] Transforms: Data grid fixes. (elastic#59538) [SIEM] Fix and consolidate handling of error responses in the client (elastic#59438) [Maps] convert tooltip classes to typescript (elastic#59589) [ML] Functional tests - re-activate date_nanos test (elastic#59649) Move canvas to use NP Expressions service (elastic#58387) Update misc dependencies (elastic#59542) [Unit Testing] Configure react-testing-library queries to use Kibana's data-test-subj instead of default data-testid (elastic#59445) [Console] Remove unused code (elastic#59554) [Logs / Metrics UI] Link handling / stop page reloads (elastic#58478) Add SavedObject management section registration in core (elastic#59291)
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Mar 11, 2020
Switched out the textfield in the advanced JSON editor for the EUI code editor component. removed legacy import isValidJson in favor of using Ace Editor's default json validation.
Contributor
|
Can these failures be related to this PR? |
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Mar 12, 2020
ThomThomson
added a commit
that referenced
this pull request
Mar 13, 2020
Switched out the textfield in the advanced JSON editor for the EUI code editor component. removed legacy import isValidJson in favor of using Ace Editor's default json validation. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the text area for the JSON input in the advanced section of the visualize editor. with the EUI code editor.
closes #56488
Checklist
Delete any items that are not applicable to this PR.
For maintainers