[@kbn/optimizer] prevent error when all bundles are cached#57871
Merged
spalger merged 1 commit intoelastic:masterfrom Feb 18, 2020
Merged
[@kbn/optimizer] prevent error when all bundles are cached#57871spalger merged 1 commit intoelastic:masterfrom
spalger merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
approved these changes
Feb 18, 2020
mistic
approved these changes
Feb 18, 2020
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This was referenced Feb 18, 2020
spalger
pushed a commit
that referenced
this pull request
Feb 19, 2020
Contributor
Author
|
7.7/7.x: df56d06 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing #57869 I realized that running the
@kbn/optimizernormally (not in watch mode) if all the bundles were cached the new completion handler added in #57735 gets confused and throws an error. This just expands that handler with a check for this situation and an integration test to make sure it keeps working.