[@kbn/optimizer] rewrite url(ui/*) in legacy scss files#57869
Merged
spalger merged 3 commits intoelastic:masterfrom Feb 18, 2020
Merged
[@kbn/optimizer] rewrite url(ui/*) in legacy scss files#57869spalger merged 3 commits intoelastic:masterfrom
spalger merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
Feb 18, 2020
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Feb 18, 2020
* [@kbn/optimizer] rewrite url(ui/*) in legacy scss files * update kbn/pm dist
Contributor
Author
|
7.x/7.7: bff96ab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@azasypkin realized that the global mixins for scss don't work because we're not remapping
ui/*imports in the new platform optimizer (by design) but we still import a couple legacy files where that is necessary. To fix this I've added theresolve-url-loaderto the@kbn/optimizerwebpack config and I'm now rewriting theui/*imports in scss files which are also in any directory namedlegacy.