Advanced Settings management app to kibana platform plugin#56931
Merged
mattkime merged 35 commits intoelastic:masterfrom Feb 11, 2020
Merged
Advanced Settings management app to kibana platform plugin#56931mattkime merged 35 commits intoelastic:masterfrom
mattkime merged 35 commits intoelastic:masterfrom
Conversation
…s_mgmt_app_to_kibana_platform
Contributor
Author
|
@elasticmachine merge upstream |
…:mattkime/kibana into adv_settings_mgmt_app_to_kibana_platform
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
…:mattkime/kibana into adv_settings_mgmt_app_to_kibana_platform
mattkime
commented
Feb 9, 2020
| // const queryText = this.props.match.params.query || ''; | ||
| const { queryText } = this.props; | ||
| const parsedQuery = Query.parse(queryText ? `ariaName:"${getAriaName(queryText)}"` : ''); | ||
| // const parsedQuery = Query.parse(queryText ? `ariaName:"${getAriaName(queryText)}"` : ''); |
Contributor
Author
There was a problem hiding this comment.
Need to figure out what this was for. Not functional in master.
Contributor
Author
There was a problem hiding this comment.
Seems this was useful minus including ariaName
pgayvallet
approved these changes
Feb 10, 2020
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
LGTM for platform change once comments are addressed
cchaos
approved these changes
Feb 10, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
The SASS file moves are fine, though there really should be an _index.scss file within the new kibana/src/plugins/advanced_settings/public/ folder that then does all the imports of it's individual SASS files.
streamich
approved these changes
Feb 10, 2020
Contributor
streamich
left a comment
There was a problem hiding this comment.
LGTM, tested on Mac/Chrome. I just have two comments about tests below.
...lugins/advanced_settings/public/management_app/__snapshots__/advanced_settings.test.tsx.snap
Outdated
Show resolved
Hide resolved
...ins/advanced_settings/public/management_app/components/form/__snapshots__/form.test.tsx.snap
Outdated
Show resolved
Hide resolved
src/plugins/advanced_settings/public/management_app/components/form/form.test.tsx
Outdated
Show resolved
Hide resolved
src/plugins/advanced_settings/public/management_app/components/form/form.test.tsx
Show resolved
Hide resolved
cchaos
reviewed
Feb 10, 2020
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Feb 11, 2020
…6931) * advanced settings component registry to new platform
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 11, 2020
* master: (27 commits) Include actions new platform plugin for codeowners (elastic#57252) [APM][docs] 7.6 documentation updates (elastic#57124) Expressions refactor (elastic#54342) [ML] New Platform server shim: update annotation routes to use new platform router (elastic#57067) Remove injected ui app vars from Canvas (elastic#56190) update max_anomaly_score route schema to handle possible undefined values (elastic#57339) [Add panel flyout] Moving create new to the top of SavedObjectFinder (elastic#56428) Add mock of a legacy ui api to re-enable Canvas storybook (elastic#56673) [monitoring] Removes noisy event received log (elastic#57275) Remove use of copied MANAGEMENT_BREADCRUMBS and use `setBreadcrumbs` from management section's mount (elastic#57324) Advanced Settings management app to kibana platform plugin (elastic#56931) [ML] New Platform server shim: update recognize modules routes to use new platform router (elastic#57206) [ML] Fix overall stats for saved search on the Data Visualizer page (elastic#57312) [ML] [NP] Removing ui imports (elastic#56358) [SIEM] Fixes failing Cypress tests (elastic#57202) Create observability CODEOWNERS reference (elastic#57109) fix results service schema (elastic#57217) don't register a wrapper if browser side function exists. (elastic#57196) Ui Actions explorer example (elastic#57006) Fix update alert API to still work when AAD is out of sync (elastic#57039) ...
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move Advanced Settings to its own kibana platform plugin.
Checklist
Delete any items that are not applicable to this PR.
[ ] Documentation was added for features that require explanation or tutorialsFor maintainers