Skip to content

[Canvas] Add mock of a legacy ui api to re-enable Canvas storybook#56673

Merged
poffdeluxe merged 6 commits intoelastic:masterfrom
poffdeluxe:canvas-fix-old-style-storybook
Feb 11, 2020
Merged

[Canvas] Add mock of a legacy ui api to re-enable Canvas storybook#56673
poffdeluxe merged 6 commits intoelastic:masterfrom
poffdeluxe:canvas-fix-old-style-storybook

Conversation

@poffdeluxe
Copy link
Copy Markdown
Contributor

Summary

Title says it all. We recently changed how we were handling toast notifications in Canvas and a new mock needed to be applied in order to get storybook building again.

@poffdeluxe poffdeluxe added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.7.0 labels Feb 3, 2020
@poffdeluxe poffdeluxe requested a review from a team as a code owner February 3, 2020 20:13
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@poffdeluxe
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@poffdeluxe
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@poffdeluxe
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@poffdeluxe
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@poffdeluxe
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@poffdeluxe poffdeluxe merged commit 57f5924 into elastic:master Feb 11, 2020
@poffdeluxe poffdeluxe deleted the canvas-fix-old-style-storybook branch February 11, 2020 18:07
poffdeluxe added a commit that referenced this pull request Feb 11, 2020
…57351)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 11, 2020
* master: (27 commits)
  Include actions new platform plugin for codeowners (elastic#57252)
  [APM][docs] 7.6 documentation updates (elastic#57124)
  Expressions refactor (elastic#54342)
  [ML] New Platform server shim: update annotation routes to use new platform router  (elastic#57067)
  Remove injected ui app vars from Canvas (elastic#56190)
  update max_anomaly_score route schema to handle possible undefined values (elastic#57339)
  [Add panel flyout] Moving create new to the top of SavedObjectFinder (elastic#56428)
  Add mock of a legacy ui api to re-enable Canvas storybook (elastic#56673)
  [monitoring] Removes noisy event received log (elastic#57275)
  Remove use of copied MANAGEMENT_BREADCRUMBS and use `setBreadcrumbs` from management section's mount (elastic#57324)
  Advanced Settings management app to kibana platform plugin (elastic#56931)
  [ML] New Platform server shim: update recognize modules routes to use new platform router (elastic#57206)
  [ML] Fix overall stats for saved search on the Data Visualizer page (elastic#57312)
  [ML] [NP] Removing ui imports (elastic#56358)
  [SIEM] Fixes failing Cypress tests (elastic#57202)
  Create observability CODEOWNERS reference (elastic#57109)
  fix results service schema (elastic#57217)
  don't register a wrapper if browser side function exists. (elastic#57196)
  Ui Actions explorer example (elastic#57006)
  Fix update alert API to still work when AAD is out of sync (elastic#57039)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants